Re: [hibernate-dev] [Search] ElasticSearch - Progress on faceting

2016-02-05 Thread Guillaume Smet
Hi Gunnar, On Thu, Feb 4, 2016 at 7:01 PM, Gunnar Morling wrote: > > - I introduced a JsonBuilder to make the gson API chainable: I think it's > > more readable this way. I haven't updated everything to use it > (especially > > the Lucene Query -> Json part is not ported yet). Should I continue

Re: [hibernate-dev] [Search] ElasticSearch - Progress on faceting

2016-02-04 Thread Hardy Ferentschik
Hi Guillaume, Awesome to see so much activity, especially in an area which I used to work on so much. I think it is great that we get some more eyes on the code now. What you say makes sense from a birds eye perspective. I am hoping that I will find some time soon to have a closer look at your su

Re: [hibernate-dev] [Search] ElasticSearch - Progress on faceting

2016-02-04 Thread Gunnar Morling
Hi Guillaume, Awesome, great to see you making progress here! I need to take a closer look, but some quick comments inline. @Sanne, this reminds me of that pending PR of mine; Any chance you spend some cycles reviewing and merging it? Guillaume's work is based on it and it'll also serve as base o