Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-12-02 Thread Emmanuel Bernard
>> Regarding the removal of Configuration in general, there will be some more >> work to be done in OGM. We have a custom sub-class, OgmConfiguration [3], >> which is used for two purposes: >> >> 1) Set some properties automatically (to enable OGM's naming strategy and >> query translator etc., u

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-12-02 Thread Gunnar Morling
2014-12-01 21:22 GMT+01:00 Steve Ebersole : > Wanted to point out that I carried those signatures on to the persister > ctors as well. > Thx. In Amsterdam we had talked about OGM needing a bootstrap hook for the point > just after all persisters have been built. Exactly what information did > t

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-12-02 Thread Gunnar Morling
2014-12-01 18:28 GMT+01:00 Steve Ebersole : > As for the "parameter object", I came up with a decent (imo) solution. So > I only wrap the things that are "contextual". Here is the contract right > now: > > > public interface PersisterFactory extends Service { > /** > * "Parameter object" provid

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-12-01 Thread Steve Ebersole
Wanted to point out that I carried those signatures on to the persister ctors as well. In Amsterdam we had talked about OGM needing a bootstrap hook for the point just after all persisters have been built. Exactly what information did that hook need access to? On Mon, Dec 1, 2014 at 11:28 AM, St

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-12-01 Thread Steve Ebersole
As for the "parameter object", I came up with a decent (imo) solution. So I only wrap the things that are "contextual". Here is the contract right now: public interface PersisterFactory extends Service { /** * "Parameter object" providing access to additional information that may be needed *

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-11-27 Thread Steve Ebersole
Actually, I take that back about Metadata extending org.hibernate.cfg.Mappings. I had contemplated doing that, but decided against it since Mappings exposes all kinds of "extra" stuff that isn't actually mappings/metadata (config info, contextual info, etc) and I did not want to fuglify these new c

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-11-27 Thread Steve Ebersole
Well naturally there is still access to all this information :) IMO SessionFactoryObserver is a hack way of doing this. With 5.0, the way to do this would be one of the various bootstrap hooks I mentioned earlier. Specifically you want a hook that is called just after all metadata is fully known

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-11-27 Thread Steve Ebersole
On Thu, Nov 27, 2014 at 3:13 AM, Gunnar Morling wrote: > Hi, > > 2014-11-27 1:23 GMT+01:00 Steve Ebersole : > >> Part of the goals for ORM 5.0 is moving from Configuration to the >> ServiceRegistry+Metadata for building a SessionFactory. >> >> One of the points I ran into that will have to change

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-11-27 Thread Emmanuel Bernard
To add on Gunnar’s needs 3. Use Configuration to extract physical Table structure We also use configuration in the SchemaDefiner The SchemaDefiner received the Configuration from a custom implementation of SessionFactoryObserver and use it during sessionFactoryCreated. The reason we use Configu

Re: [hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-11-27 Thread Gunnar Morling
Hi, 2014-11-27 1:23 GMT+01:00 Steve Ebersole : > Part of the goals for ORM 5.0 is moving from Configuration to the > ServiceRegistry+Metadata for building a SessionFactory. > > One of the points I ran into that will have to change > is org.hibernate.persister.spi.PersisterFactory. The problems i

[hibernate-dev] org.hibernate.persister.spi.PersisterFactory and 5.0

2014-11-26 Thread Steve Ebersole
Part of the goals for ORM 5.0 is moving from Configuration to the ServiceRegistry+Metadata for building a SessionFactory. One of the points I ran into that will have to change is org.hibernate.persister.spi.PersisterFactory. The problems is that PersisterFactory accepts a Configuration as part of