Re: [hibernate-dev] integrate Envers with new metamodel

2012-08-18 Thread Steve Ebersole
The general idea is good. But not really getting the point/purpose of having both before and after hooks. On 08/17/2012 01:12 AM, Strong Liu wrote: > I'm thinking add the interface below, with it, modules like envers can choose > either before or after the metamodel get processed to hook into i

Re: [hibernate-dev] integrate Envers with new metamodel

2012-08-16 Thread Strong Liu
I'm thinking add the interface below, with it, modules like envers can choose either before or after the metamodel get processed to hook into its own extending mappings public interface MetadataContributingIntegrator extends Integrator { /** * Allow the integrator to alter the

Re: [hibernate-dev] integrate Envers with new metamodel

2012-08-01 Thread Hardy Ferentschik
On 31 Jan 2012, at 10:55 PM, Sanne Grinovero wrote: > Why is the "annotation indexing" discussion part of the metamodel? Why not? We are using Jandex in the new metamodel which is a annotation index/repository > I initially understood that a replacement of commons-annotations was > being devel

Re: [hibernate-dev] integrate Envers with new metamodel

2012-08-01 Thread Hardy Ferentschik
On 31 Jan 2012, at 10:49 PM, Strong Liu wrote: > maybe we should move the annotation indexing from > org.hibernate.metamodel.internal.source.annotations.AnnotationMetadataSourceProcessorImpl#AnnotationMetadataSourceProcessorImpl > into MetadataSources ( for hbm, it can be get by > org.hibernat

Re: [hibernate-dev] integrate Envers with new metamodel

2012-07-31 Thread Strong Liu
that part is developed to replace commons-annotations, but it is not designed as a separated module, but part of hibernate-orm. because of using Jandex, this code is much simpler now, so there is no need to do that. for modules like h-search which doesn't depend on ORM, maybe it should move to

Re: [hibernate-dev] integrate Envers with new metamodel

2012-07-31 Thread Sanne Grinovero
Why is the "annotation indexing" discussion part of the metamodel? I initially understood that a replacement of commons-annotations was being developed, which would be nice for Search too as Search does not and should not depend on Hibernate ORM. Cheers, Sanne On 31 July 2012 23:49, Strong Liu w

Re: [hibernate-dev] integrate Envers with new metamodel

2012-07-31 Thread Strong Liu
maybe we should move the annotation indexing from org.hibernate.metamodel.internal.source.annotations.AnnotationMetadataSourceProcessorImpl#AnnotationMetadataSourceProcessorImpl into MetadataSources ( for hbm, it can be get by org.hibernate.metamodel.MetadataSources#getJaxbRootList) and add a n

Re: [hibernate-dev] integrate Envers with new metamodel

2012-07-31 Thread Sanne Grinovero
Both Hibernate Search and Hibernate OGM will need to look for custom annotations as well. On 30 July 2012 22:59, Strong Liu wrote: > https://hibernate.onjira.com/browse/HHH-7490 > > the problem is, envers needs to index its own annotations ( @Audited for > example ), but the current Integrator

[hibernate-dev] integrate Envers with new metamodel

2012-07-30 Thread Strong Liu
https://hibernate.onjira.com/browse/HHH-7490 the problem is, envers needs to index its own annotations ( @Audited for example ), but the current Integrator api only passes in a Metadata instance. so, we either pass in the Index or the MetadataImplementor has access to the all mapping entities