Re: [hibernate-dev] Wrong JdbcServicesImpl configuration with problematic connection

2011-06-08 Thread Dmitry Geraskov
Thanks to Hardy I was able to run tests from hibernate git repository. Due to changes since Aplha3 my patch didn't fix the problem. The change is about how serviceRegistry.getService( ConnectionProvider.class ) works - earlier service#configure was not called on this call and there was no atte

Re: [hibernate-dev] Wrong JdbcServicesImpl configuration with problematic connection

2011-06-08 Thread Dmitry Geraskov
Here is the link to the request: https://github.com/hibernate/hibernate-core/pull/103 08/06/2011 9:56, Dmitry Geraskov wrote: > Done, > please check my pull request. > > 06/06/2011 15:15, Steve Ebersole wrote: >> Then please create a test case that illustrates this problematic >> behavior and ide

Re: [hibernate-dev] Wrong JdbcServicesImpl configuration with problematic connection

2011-06-07 Thread Dmitry Geraskov
Done, please check my pull request. 06/06/2011 15:15, Steve Ebersole wrote: > > Then please create a test case that illustrates this problematic > behavior and ideally create a pull request fixing said behavior > > On Jun 6, 2011 5:01 AM, "Dmitry Geraskov" > wrote: >

Re: [hibernate-dev] Wrong JdbcServicesImpl configuration with problematic connection

2011-06-06 Thread Steve Ebersole
Then please create a test case that illustrates this problematic behavior and ideally create a pull request fixing said behavior On Jun 6, 2011 5:01 AM, "Dmitry Geraskov" wrote: > Hey, guys, > > I decided to write to this list to force this mistake to be fixed in Beta1. > > There is a widely used

[hibernate-dev] Wrong JdbcServicesImpl configuration with problematic connection

2011-06-06 Thread Dmitry Geraskov
Hey, guys, I decided to write to this list to force this mistake to be fixed in Beta1. There is a widely used class JdbcServicesImpl in hibernate4. In the configure(Map configValues) it gets Connection object and does the configuration. But what if the connection can't be established? It do som