Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Steve Ebersole
Looks like I missed a small piece there. The intention was to have TypeSafeActivator pick up SessionFactoryOptions#getValidatorFactoryReference. Scott, can you make sure SessionFactoryOptions#getValidatorFactoryReference contains the proper ValidatorFactory reference when we get into TypeSafeActi

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
Steve, I created HHH-9905 for this, which I was able to workaround with a quick hack (set the missing "javax.persistence.validation.factory" property in the ConfigurationService). I was able to pass the WildFly test with the workaround. Steve, is that the right fix? I assigned the jira to yo

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
Hi, > http://pastebin.com/4X0h1VPA is the call stack in. We are in the second > bootstrap phase, which is good. The validator factory is passed into the > integration properties but we are only checking the persistence unit > properties in ORM 5. Since we are not looking in the integration pro

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 09:32 AM, Hardy Ferentschik wrote: > On Wed, Jul 08, 2015 at 09:11:55AM -0400, Scott Marlow wrote: >>> Just fishing here, but "integration code and the ORM 5 persistence >>> provider" might >>> indicate a problem in the persistence bootstrapping. >>> Have a look at >>> org.hiberna

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl#populate(SessionFactoryBuilder sfBuilder, StandardServiceRegistry ssr) does pass the correct VF to sfBuilder.applyValidatorFactory (using the ValidatorFactory passed to the EntityManagerFactoryBuilderImpl.withValidatorFactory). Ho

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
On Wed, Jul 08, 2015 at 09:11:55AM -0400, Scott Marlow wrote: > >Just fishing here, but "integration code and the ORM 5 persistence provider" > >might > >indicate a problem in the persistence bootstrapping. > >Have a look at > >org.hibernate.cfg.beanvalidation.TypeSafeActivator#getValidatorFactor

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 09:02 AM, Hardy Ferentschik wrote: > Hi, > >> The same test works with the WildFly master branch, which is using ORM >> 4.3.x. The Bean Validation integration code is unchanged in my WildFly >> branch, as is the Bean Validator. The only thing different, is the ORM 5 >> integration

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 09:02 AM, Hardy Ferentschik wrote: > Hi, > >> The same test works with the WildFly master branch, which is using ORM >> 4.3.x. The Bean Validation integration code is unchanged in my WildFly >> branch, as is the Bean Validator. The only thing different, is the ORM 5 >> integration

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
Hi, > The same test works with the WildFly master branch, which is using ORM > 4.3.x. The Bean Validation integration code is unchanged in my WildFly > branch, as is the Bean Validator. The only thing different, is the ORM 5 > integration code and the ORM 5 persistence provider. Just fishing he

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
Here are a few different call stacks: 1. http://pastebin.com/ZiZL5vEh shows the call stack when running against the WildFly master branch (with ORM 4.3.x) and the @Inject works (the test org.jboss.as.test.integration.jpa.beanvalidation.cdi.CustomMinValidator.setMinimumValueProvider() method

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Gunnar Morling
Scott, could you update the Gist with the complete stack trace you got? It seems to only contains parts of it. 2015-07-08 14:32 GMT+02:00 Scott Marlow : > > > On 07/08/2015 08:16 AM, Hardy Ferentschik wrote: > > On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: > >> To recreate the Wi

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 08:16 AM, Hardy Ferentschik wrote: > On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: >> To recreate the WildFly ORM 5 issue on WildFly (if you want to see it >> yourself), steps are: > > For the record, I see the same test failures locally. I have not looked any > furt

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 07:15 AM, Sanne Grinovero wrote: > On 8 July 2015 at 11:42, Hardy Ferentschik wrote: >> On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: >>> Hardy, >>> >>> It seems that the ValidatorFactoryBean#createConstraintValidatorFactory is >>> getting called too late for some r

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: > To recreate the WildFly ORM 5 issue on WildFly (if you want to see it > yourself), steps are: For the record, I see the same test failures locally. I have not looked any further regarding their cause. @Scott, on a high level what are

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Sanne Grinovero
On 8 July 2015 at 11:42, Hardy Ferentschik wrote: > On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: >> Hardy, >> >> It seems that the ValidatorFactoryBean#createConstraintValidatorFactory is >> getting called too late for some reason. http://pastebin.com/WrdD91Hr shows >> the call st

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: > Hardy, > > It seems that the ValidatorFactoryBean#createConstraintValidatorFactory is > getting called too late for some reason. http://pastebin.com/WrdD91Hr shows > the call stack for > ValidatorFactoryBean#create(CreationalContext c

[hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-07 Thread Scott Marlow
Hardy, It seems that the ValidatorFactoryBean#createConstraintValidatorFactory is getting called too late for some reason. http://pastebin.com/WrdD91Hr shows the call stack for ValidatorFactoryBean#create(CreationalContext ctx) which calls createConstraintValidatorFactory, which seems too late