Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Steve Ebersole
I tend to agree with Gail in regards to ORM. Even if it is just fixing a small typo, just use the original Jira key that introduced the typo IMO On Mon, Apr 18, 2016 at 12:38 PM Gail Badner wrote: > I have no problem if you want to do this for non-ORM; however, I've seen > bugs get introduced b

Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Gail Badner
I have no problem if you want to do this for non-ORM; however, I've seen bugs get introduced by "clean up" commits in ORM. Fixing these regressions are easier to find and track if there is a "clean up" jira. On Mon, Apr 18, 2016 at 5:54 AM, Vlad Mihalcea wrote: > +1 > > Vlad > > On Mon, Apr 18,

Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Vlad Mihalcea
+1 Vlad On Mon, Apr 18, 2016 at 3:48 PM, Guillaume Smet wrote: > OK for me too. That's what I was told when I asked the question a while ago > :). > > On Mon, Apr 18, 2016 at 2:15 PM, Sanne Grinovero > wrote: > > > This question came up again on github; seems Gunnar, Davide and myself > > woul

Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Guillaume Smet
OK for me too. That's what I was told when I asked the question a while ago :). On Mon, Apr 18, 2016 at 2:15 PM, Sanne Grinovero wrote: > This question came up again on github; seems Gunnar, Davide and myself > would agree on preferring a little more flexibility on the no-orm > projects than ORM

[hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Sanne Grinovero
This question came up again on github; seems Gunnar, Davide and myself would agree on preferring a little more flexibility on the no-orm projects than ORM's guidelines: - https://github.com/hibernate/hibernate-search/pull/1064#issuecomment-211320931 This flexibility would be a perk for regular