Done. I updated the pull request to have the "/" check first:
https://github.com/hibernate/hibernate-orm/pull/1295
Vlad
On Thu, Mar 10, 2016 at 2:18 PM, Steve Ebersole wrote:
> I dislike having to instantiate File just to check. Please leave the
> pre-emptive "/" check before instantiating th
I dislike having to instantiate File just to check. Please leave the
pre-emptive "/" check before instantiating the File.
On Thu, Mar 10, 2016 at 4:16 AM Emmanuel Bernard
wrote:
> Right exactly. We ended up requiring persistence.xml and realized that
> not having a specific extension was not
Right exactly. We ended up requiring persistence.xml and realized that
not having a specific extension was not hurting performance and
feasibility.
On Wed 2016-03-09 22:49, Steve Ebersole wrote:
> A PAR is just an archive with a META-INF/persistence.xml file in it. The
> JPA spec does cover this.
I would go for the conservative side. This code was very tedious to
stabilize on all crazy types of URL one can receive (http, file on
various OSes, osgi, custom container url schemes, etc.).
On Thu 2016-03-10 9:52, Vlad Mihalcea wrote:
> The fix goes like this:
>
> if ( filePart.startsWith( "/"
The fix goes like this:
if ( filePart.startsWith( "/" ) || new File(url.getFile()).isAbsolute() ) {
// the URL is already an absolute form
return url;
}
The reason why it works on Linux/Macs is that absolute paths start with "/".
With this fix works on Windows too, but I wonder if we shoul
Hi,
I managed to find what caused this test to start failing. The reason is
this commit:
Commit: 5c77f279afaecb505f7a22bfa05c172b493096bd [5c77f27]
Parents: 8670b4211e
Author: Steve Ebersole
Date: Tuesday, January 12, 2016 11:21:54 PM
Commit Date: Tuesday, January 12, 2016 11:22:19 PM
Labels: HE
A PAR is just an archive with a META-INF/persistence.xml file in it. The
JPA spec does cover this. The extension is irrelevant.
On Wed, Mar 9, 2016 at 4:08 PM Sanne Grinovero wrote:
> I remember JBoss had "HAR" deployments to package Hibernate models and
> PU definitions.. as far as I know thi
I remember JBoss had "HAR" deployments to package Hibernate models and
PU definitions.. as far as I know this was a JBoss only thing, it
wouldn't surprise me if other app servers experimented with similar
non-standardized archives.
https://docs.jboss.org/jbossas/jboss4guide/r3/html/ch13.html
On 9
Hi,
The part is backslashes comes from the absolute path set by Gradle when
supplying the module OS folder.
The right part containing slashes is the one set in persistence.xml.
I'll try to replace backslashes with slashes and see how it goes.
I was curious if people use the jar-file with absolute
We usually strive on having functionalities work on both Java EE and
Java SE.
you example though shows a mix of forward and backslash in your
, is that expected ?
Emmanuel
On Wed 2016-03-09 17:05, Vlad Mihalcea wrote:
> Hi,
>
> I have two tests in the PackagedEntityManagerTest unit test that fai
Hi,
I have two tests in the PackagedEntityManagerTest unit test that fail on my
machine, but work just fine for everybody else.
It could be an OS thing or not, but during the check, I found hat we are
testing against an use case that is not found in the JPA spec.
The testExternalJar() creates an
11 matches
Mail list logo
