Re: [hibernate-dev] Table and quoted names

2010-10-04 Thread Juraci Paixao Krohling
On 10/01/2010 07:57 PM, Steve Ebersole wrote: > The vast majority of databases out there have more or less decent JDBC > drivers. So forcing every single Dialect to reproduce information that > is already correctly available to us because of a few *known* slackers > seems silly. Why can't the maj

Re: [hibernate-dev] Table and quoted names

2010-10-04 Thread Max Rydahl Andersen
>> Totally agreedI guess the question is though if that is going to part of >> what we >> today call Dialect or something else (If i follow Steve's comments right) > > The vast majority of databases out there have more or less decent JDBC > drivers. Actually, that ain't true when it comes t

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Steve Ebersole
On Fri, 2010-10-01 at 18:26 +0200, Max Rydahl Andersen wrote: > >> I'd like to figure out if this could be determined by looking at the > >> DatabaseMetaData before making the Dialects have to specify this. With > >> the Dialects its just another thing we need to "keep in synch". Not > >> sure if

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Max Rydahl Andersen
>> Ok, saw it now. >> >> I'm eery to requiring databasemetadata access as part of the Table model >> since I (at least until now) have >> been using them extensively without wanting to require a running db...(which >> is not a requirement today). > > I have to be honest that I fail to grasp whe

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Max Rydahl Andersen
>> I'd like to figure out if this could be determined by looking at the >> DatabaseMetaData before making the Dialects have to specify this. With >> the Dialects its just another thing we need to "keep in synch". Not >> sure if you saw my comments in ObjectName wrt DatabaseMetaData, but >> those

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Steve Ebersole
On Fri, 2010-10-01 at 15:57 +0200, Max Rydahl Andersen wrote: > > I'd like to figure out if this could be determined by looking at the > > DatabaseMetaData before making the Dialects have to specify this. With > > the Dialects its just another thing we need to "keep in synch". Not > > sure if you

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Juraci Paixao Krohling
On 10/01/2010 03:20 PM, Steve Ebersole wrote: > I'd like to figure out if this could be determined by looking at the > DatabaseMetaData before making the Dialects have to specify this. With > the Dialects its just another thing we need to "keep in synch". Not > sure if you saw my comments in Obje

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Max Rydahl Andersen
>> >> Looking at it reminded me of >> http://opensource.atlassian.com/projects/hibernate/browse/HHH-1476 >> >> The problem of the separators actually having to be dialect controlled and >> even in some cases schema >> can be skipped resulting in catalog..table. Worth covering ? > > I'd like to

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Steve Ebersole
On Fri, 2010-10-01 at 14:31 +0200, Max Rydahl Andersen wrote: > Got them this time. > > Looks like quoting is done all good there. > > Looking at it reminded me of > http://opensource.atlassian.com/projects/hibernate/browse/HHH-1476 > > The problem of the separators actually having to be dialec

Re: [hibernate-dev] Table and quoted names

2010-10-01 Thread Max Rydahl Andersen
Got them this time. Looks like quoting is done all good there. Looking at it reminded me of http://opensource.atlassian.com/projects/hibernate/browse/HHH-1476 The problem of the separators actually having to be dialect controlled and even in some cases schema can be skipped resulting in catalo

Re: [hibernate-dev] Table and quoted names

2010-09-30 Thread Steve Ebersole
Sigh... https://fisheye2.atlassian.com/browse/Hibernate4/src/main/java/org/hibernate/metamodel/schema/Identifier.java?r=1e336e607552dd638cee382cb43ed914112ed255 https://fisheye2.atlassian.com/browse/Hibernate4/src/main/java/org/hibernate/metamodel/schema/ObjectName.java?r=1e336e607552dd638cee382cb

Re: [hibernate-dev] Table and quoted names

2010-09-30 Thread Steve Ebersole
Hmm a few other people said they did not get them either. Trying again... On Thu, 2010-09-30 at 10:37 -0500, Steve Ebersole wrote: > ? > > They came back through to me. > > On Thu, 2010-09-30 at 17:21 +0200, Max Rydahl Andersen wrote: > > missing attachement? > > > > /max > > > > On Sep 30,

Re: [hibernate-dev] Table and quoted names

2010-09-30 Thread Steve Ebersole
? They came back through to me. On Thu, 2010-09-30 at 17:21 +0200, Max Rydahl Andersen wrote: > missing attachement? > > /max > > On Sep 30, 2010, at 15:01, Steve Ebersole wrote: > > > True enough. Attached is the code I developed for Hibernate 4 to handle > > this better. Care to gander?

Re: [hibernate-dev] Table and quoted names

2010-09-30 Thread Max Rydahl Andersen
missing attachement? /max On Sep 30, 2010, at 15:01, Steve Ebersole wrote: > True enough. Attached is the code I developed for Hibernate 4 to handle > this better. Care to gander? > > > On Thu, 2010-09-30 at 15:09 +0300, Dmitry Geraskov wrote: >> Hi, guys, >> while I was fixing some bug in h

Re: [hibernate-dev] Table and quoted names

2010-09-30 Thread Steve Ebersole
True enough. Attached is the code I developed for Hibernate 4 to handle this better. Care to gander? On Thu, 2010-09-30 at 15:09 +0300, Dmitry Geraskov wrote: > Hi, guys, > while I was fixing some bug in hibernate tools I looked through some > hibernate code. > And it seems to me that hibernat

[hibernate-dev] Table and quoted names

2010-09-30 Thread Dmitry Geraskov
Hi, guys, while I was fixing some bug in hibernate tools I looked through some hibernate code. And it seems to me that hibernate is not ready in some cases for quoted identifiers. Here I would like to highlight some potentially weak places in key class org.hibernate.mapping.Table. It doesn't