Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-08-01 Thread Sanne Grinovero
On 1 August 2013 06:54, Steve Ebersole wrote: > See inline... > > On 07/31/2013 06:08 AM, Sanne Grinovero wrote: > >> # Hibernate: >> >> Probably the best finding is the 'Shared non-thread-safe content' >> finding in the class 'EntityManagerFactoryRegistry'. In general, the >> inconsistent and mix

Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-08-01 Thread Scott Marlow
On 08/01/2013 10:41 AM, Scott Marlow wrote: >>> - The shared non-thread-safe content finding looks like it spots a >>> symptom of a real bug: in the method 'getNamedEntityManagerFactory', a >>> hashmap is extracted from a concurrent hash map and read from. >>> Concurrently, there is

Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-08-01 Thread Scott Marlow
>> - The shared non-thread-safe content finding looks like it spots a >> symptom of a real bug: in the method 'getNamedEntityManagerFactory', a >> hashmap is extracted from a concurrent hash map and read from. >> Concurrently, there is the possibility that items are removed from the >>

Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-07-31 Thread Steve Ebersole
See inline... On 07/31/2013 06:08 AM, Sanne Grinovero wrote: > # Hibernate: > > Probably the best finding is the 'Shared non-thread-safe content' > finding in the class 'EntityManagerFactoryRegistry'. In general, the > inconsistent and mixed synchronisation findings are not very good, but > the (

Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-07-31 Thread Steve Ebersole
I can look after I get done mucking around with the JPA TCK... On 07/31/2013 06:08 AM, Sanne Grinovero wrote: > Hi all, > the ThreadSafe team (http://contemplateltd.com) kindly offered a trial > license to inspect Hibernate and Infinispan projects for code > correctness; you can think of this as t

[hibernate-dev] Static analysis report on thread safety of Hibernate

2013-07-31 Thread Sanne Grinovero
Hi all, the ThreadSafe team (http://contemplateltd.com) kindly offered a trial license to inspect Hibernate and Infinispan projects for code correctness; you can think of this as the "Findbugs for concurrent code". The idea is to mutually benefit from it: we get to use the tool, but we should also