Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-13 Thread Shaozhuang Liu
is there a way to do it w/ Intellij? I think it would be good idea to apply this annotation on orm as well - Best Regards, Strong Liu http://about.me/stliu/bio On Aug 12, 2013, at 9:42 PM, Guillaume Smet wrote: > Hi, > > On Fri, Aug 9, 2013 at 6:41 PM, Guillaume Smet

Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-12 Thread Guillaume Smet
Hi, On Fri, Aug 9, 2013 at 6:41 PM, Guillaume Smet wrote: > I'll see what I can do about it as everyone seems to agree with it. Done thanks to Eclipse quick fix: https://hibernate.atlassian.net/browse/HSEARCH-1387 https://github.com/hibernate/hibernate-search/pull/467 It would probably be a goo

Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-09 Thread Guillaume Smet
Hi Gunnar, On Fri, Aug 9, 2013 at 6:19 PM, Gunnar Morling wrote: > Not sure though whether an ad-hoc action is required to add it everywhere. > In Eclipse I'm having a "save action" which adds it to every file I'm > touching in the course of other work I'm doing. I don't like that much this sort

Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-09 Thread Sanne Grinovero
+1 to add them, but I might then need to remove some specific ones when we test compatibility vs. older Hibernate ORM versions. Sometimes we implement methods which are not defined on an older version of the API, having the @Override on it doesn't make it compile. But feel free to add them everywhe

Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-09 Thread Gunnar Morling
+1 We're doing the same in HV. Not sure though whether an ad-hoc action is required to add it everywhere. In Eclipse I'm having a "save action" which adds it to every file I'm touching in the course of other work I'm doing. --Gunnar 2013/8/9 Hardy Ferentschik > > On 9 Jan 2013, at 5:49 PM,

Re: [hibernate-dev] Search and JDK 6: @Override annotations

2013-08-09 Thread Hardy Ferentschik
On 9 Jan 2013, at 5:49 PM, Guillaume Smet wrote: > AFAICS in the pom.xml, Search is now compiled for Java 6. > > I think It would be a good idea to add the @Override annotation to the > methods implemented from an interface, considering it's supported in > Java 6. +1 --Hardy

[hibernate-dev] Search and JDK 6: @Override annotations

2013-08-09 Thread Guillaume Smet
Hi, AFAICS in the pom.xml, Search is now compiled for Java 6. I think It would be a good idea to add the @Override annotation to the methods implemented from an interface, considering it's supported in Java 6. I'm willing to do the grunt work and prepare a pull request in the next few days if yo