Re: [hibernate-dev] Review of HSEARCH-361 (don't index entity change

2011-01-03 Thread Emmanuel Bernard
On 3 janv. 2011, at 17:42, Sanne Grinovero wrote: > > Regarding avoiding reflection, why do we usually read the values from > the entity anyway as we have all values > already read out in the array :D ? Good to open a far-future improvement > issue? I'm talking about supporting Core 3.6.0 and

Re: [hibernate-dev] Review of HSEARCH-361 (don't index entity change

2011-01-03 Thread Sanne Grinovero
Hi Emmanuel, to adress the missing test I've prepared HSEARCH-658 ( https://github.com/hibernate/hibernate-search/pull/30 ). Would be very nice to have Core report what changed directly. BTW, anybody could elaborate on the differences between findModified and findDirty ? I just found this code:

[hibernate-dev] Review of HSEARCH-361 (don't index entity change

2011-01-03 Thread Emmanuel Bernard
Hey guys to warm up in 2011, I've reviewed HSEARCH-361. I have two remarks Can you add a unit test that checks mutable properties. I think it's covered but let's plan for a later bug :) FullTextIndexEventListener compute the list of dirty properties by calling EntityPersister.findDirty(). I don