Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-08 Thread Sanne Grinovero
Right, seems we agree then; mine is purely a quantitative approach: don't break too much in a single version, but if these have been deprecated already my comment doesn't apply. Sanne On 8 May 2015 at 19:30, Steve Ebersole wrote: > Sanne, the methods are already deprecated. You can already do t

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-08 Thread Steve Ebersole
Sanne, the methods are already deprecated. You can already do that step. For the deprecated methods that actually have a replacement anyway. But think about the ones that don't. They are the ones that are likely to "still be there" on the API and likely do absolutely nothing. Because if there w

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-08 Thread Sanne Grinovero
On 8 May 2015 at 18:33, Steve Ebersole wrote: > I don't know if I agree with this. I'll play the other side... What if you > had done the Lucene 4 upgrade and spent a bunch of time managing API changes > and finally got it right and then Lucene 4.1 cam along and removed a bunch > of deprecated me

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-08 Thread Steve Ebersole
I don't know if I agree with this. I'll play the other side... What if you had done the Lucene 4 upgrade and spent a bunch of time managing API changes and finally got it right and then Lucene 4.1 cam along and removed a bunch of deprecated methods? I think I'd actually be a tad more pissed off a

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-08 Thread Sanne Grinovero
Of course we can delete them, I just meant to stress there should be a different "appropriate moment" for: A] removal of deprecated methods for the sake of it (cleanup of old garbage) B] removal of a method during a major release (API changes allowed) because we can't otherwise get some improveme

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-05 Thread Hardy Ferentschik
On Tue, May 05, 2015 at 08:36:27AM -0500, Steve Ebersole wrote: > Why? Why even deprecate methods then? +1 --Hardy pgplBvr0yyAdf.pgp Description: PGP signature ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailm

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-05 Thread Steve Ebersole
Why? Why even deprecate methods then? On Tue, May 5, 2015 at 8:18 AM, Sanne Grinovero wrote: > Please don't remove deprecated methods if there is no real need! > > > > On 5 May 2015 at 14:12, Steve Ebersole wrote: > > In regards to the first 2 sets, yes I agree. > > > > In regards to your seco

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-05 Thread Sanne Grinovero
Please don't remove deprecated methods if there is no real need! On 5 May 2015 at 14:12, Steve Ebersole wrote: > In regards to the first 2 sets, yes I agree. > > In regards to your second point, see the discussion on > https://hibernate.atlassian.net/browse/HHH-9761 first. One idea was to > ke

Re: [hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-05 Thread Steve Ebersole
In regards to the first 2 sets, yes I agree. In regards to your second point, see the discussion on https://hibernate.atlassian.net/browse/HHH-9761 first. One idea was to keep those methods as an "untyped API". Another option would be to add another byId (etc) method for untyped operations, some

[hibernate-dev] Removing deprecated methods from Session and SessionFactory

2015-05-05 Thread Gunnar Morling
Hi, There are several deprecated methods on Session: * public Object load(Class theClass, Serializable id, LockMode lockMode) * public Object load(String entityName, Serializable id, LockMode lockMode); * public void lock(Object object, LockMode lockMode); * public void lock(String entityName, Ob