Re: [hibernate-dev] Refactor MySQL Dialects

2017-02-09 Thread Vlad Mihalcea
I created a Pull Request for this: https://github.com/hibernate/hibernate-orm/pull/1787 If you think we should not make this change, then I can close it. However, I think it's much easier if we have a single hierarchy in the MySQL Dialects. Vlad On Thu, Feb 9, 2017 at 3:28 PM, Steve Ebersole w

Re: [hibernate-dev] Refactor MySQL Dialects

2017-02-09 Thread Steve Ebersole
That is a good solution for now. Ultimately I think we still want to add some capability for Dialects to configure either themselves or the things they return based on Connection, env, etc. It's something we have discussed for some time. On Wed, Feb 8, 2017 at 1:01 AM Vlad Mihalcea wrote: > Hi

[hibernate-dev] Refactor MySQL Dialects

2017-02-07 Thread Vlad Mihalcea
Hi, While working on MariaDB Dialects, I realize that we should also refactor the MySQL ones. The problem is that we introduced the InnoDB hierarchy. Since the only difference between those two is related to 3 methods, I think we should hide them behind a MySQLStorageEngine hierarchy with InnoDB