Re: [hibernate-dev] R: [HSearch] Configuration properties

2010-07-12 Thread Hardy Ferentschik
Hi, not sure whether we can get rid of WeakIdentityHashMap. There are other uses for this class not only ContextHolder. However, I think we could remove ContextHolder and FullTextIndexCollectionEventListener. The default constructor in FullTextIndexEventListener could be deprecated and thro

Re: [hibernate-dev] R: [HSearch] Configuration properties

2010-07-12 Thread Sanne Grinovero
2010/7/12 Hardy Ferentschik : > Hi Sanne, > > I guess you are referring to HSEARCH-517 and the WeakHashMap in > ContextHolder. > Reading through the comments I am wondering whether we couldn't deprecate > the default constructor in FullTextIndexEventListener now? The > annotation module in Core has

Re: [hibernate-dev] R: [HSearch] Configuration properties

2010-07-12 Thread Hardy Ferentschik
Hi Sanne, I guess you are referring to HSEARCH-517 and the WeakHashMap in ContextHolder. Reading through the comments I am wondering whether we couldn't deprecate the default constructor in FullTextIndexEventListener now? The annotation module in Core has now been merged with the core module so

[hibernate-dev] R: [HSearch] Configuration properties

2010-07-09 Thread Sanne Grinovero
Hi Hardy! because it's the key for the static weakhashmap for the autoregistration of listeners, that would introduce a memory leak. I had proposed to care for registration of listeners in other ways, don't have the reference now from the phone (I'd +1 to remove the static weakhashmap) cheers, San