Re: [hibernate-dev] Query Parser Redesign

2015-08-27 Thread Davide D'Alto
+1 On Thu, Aug 27, 2015 at 10:09 AM, Sanne Grinovero wrote: > On 26 August 2015 at 23:20, Steve Ebersole wrote: > > I'm ok with that. Everyone else? > > > > > > On Wed, Aug 26, 2015 at 4:24 PM Gunnar Morling > wrote: > >> > >> hibernate-query-parser? > > +1 > > >> > >> 2015-08-26 22:32 GMT+02

Re: [hibernate-dev] Query Parser Redesign

2015-08-27 Thread Sanne Grinovero
On 26 August 2015 at 23:20, Steve Ebersole wrote: > I'm ok with that. Everyone else? > > > On Wed, Aug 26, 2015 at 4:24 PM Gunnar Morling wrote: >> >> hibernate-query-parser? +1 >> >> 2015-08-26 22:32 GMT+02:00 Steve Ebersole : >> > I think I'd like to rename this repo and the 2 modules. I th

Re: [hibernate-dev] Query Parser Redesign

2015-08-26 Thread Steve Ebersole
I'm ok with that. Everyone else? On Wed, Aug 26, 2015 at 4:24 PM Gunnar Morling wrote: > hibernate-query-parser? > > 2015-08-26 22:32 GMT+02:00 Steve Ebersole : > > I think I'd like to rename this repo and the 2 modules. I think its > easier > > to call the overall repo hibernate-sqm. And th

Re: [hibernate-dev] Query Parser Redesign

2015-08-26 Thread Gunnar Morling
hibernate-query-parser? 2015-08-26 22:32 GMT+02:00 Steve Ebersole : > I think I'd like to rename this repo and the 2 modules. I think its easier > to call the overall repo hibernate-sqm. And then within that rename the 2 > modules: > * hibernate-sqm -> hibernate-sqm-model > * hibernate-query-int

Re: [hibernate-dev] Query Parser Redesign

2015-08-26 Thread Steve Ebersole
I think I'd like to rename this repo and the 2 modules. I think its easier to call the overall repo hibernate-sqm. And then within that rename the 2 modules: * hibernate-sqm -> hibernate-sqm-model * hibernate-query-interpreter -> ? Still not sure what to call this "query->SQM" module. Thoughts?

Re: [hibernate-dev] Query Parser Redesign

2015-08-26 Thread Sanne Grinovero
On 26 August 2015 at 18:27, Steve Ebersole wrote: > Yes, but at this point lets make sure there is a Jira for any changes we > are making. > > Also, I wanted to be specific that *no* clients of this code belong in this > repo. I know y'all did that with the hibernate-hql-parser repo. I just > wa

Re: [hibernate-dev] Query Parser Redesign

2015-08-26 Thread Steve Ebersole
Yes, but at this point lets make sure there is a Jira for any changes we are making. Also, I wanted to be specific that *no* clients of this code belong in this repo. I know y'all did that with the hibernate-hql-parser repo. I just want to be clear that that should *not* happen here. On Wed, Au

Re: [hibernate-dev] Query Parser Redesign

2015-08-26 Thread Steve Ebersole
Yes On Wed, Aug 26, 2015, 1:48 AM Gunnar Morling wrote: > +1 for the new repo. Just forked it and am looking into the amazing > things you guys built recently :) > > Can I push simple stuff to that repo right away (e.g. adding the > Eclipse plug-in to build.gradle)? > > Cheers, > > --Gunnar > >

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread Gunnar Morling
+1 for the new repo. Just forked it and am looking into the amazing things you guys built recently :) Can I push simple stuff to that repo right away (e.g. adding the Eclipse plug-in to build.gradle)? Cheers, --Gunnar 2015-08-26 0:17 GMT+02:00 Steve Ebersole : > I also created Jira project ->

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread Steve Ebersole
I also created Jira project -> https://hibernate.atlassian.net/projects/SQM On Tue, Aug 25, 2015 at 3:56 PM Steve Ebersole wrote: > I am starting that work here -> > https://github.com/hibernate/hibernate-semantic-query > > > On Tue, Aug 25, 2015 at 2:21 PM andrea boriero > wrote: > >> no objec

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread Steve Ebersole
I am starting that work here -> https://github.com/hibernate/hibernate-semantic-query On Tue, Aug 25, 2015 at 2:21 PM andrea boriero wrote: > no objections > > On 25 August 2015 at 20:12, Steve Ebersole wrote: > >> Anyone want to propose an alternative approach to what I have working in >> my

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread andrea boriero
no objections On 25 August 2015 at 20:12, Steve Ebersole wrote: > Anyone want to propose an alternative approach to what I have working in > my Antlr 4 PoC? > > If not, I think we should move that work to a GitHub Hibernate org repo > and start tracking work and Jiras there. Objections? > > Als

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread Steve Ebersole
Anyone want to propose an alternative approach to what I have working in my Antlr 4 PoC? If not, I think we should move that work to a GitHub Hibernate org repo and start tracking work and Jiras there. Objections? Also its no longer *just* HQL, we also plan to support JPA criteria queries here,

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread andrea boriero
I see, Thanks On 25 August 2015 at 13:17, Steve Ebersole wrote: > from A a where a.b in (from B b ..) and a.c in (from C c ...) ... > > But regardless, the children are not important for a stack, just the > parent. As I said when we discussed on ORC, the children are just > maintained because

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread Steve Ebersole
from A a where a.b in (from B b ..) and a.c in (from C c ...) ... But regardless, the children are not important for a stack, just the parent. As I said when we discussed on ORC, the children are just maintained because I used them for tests. On Tue, Aug 25, 2015 at 6:53 AM andrea boriero wrote

Re: [hibernate-dev] Query Parser Redesign

2015-08-25 Thread andrea boriero
Hi Stevej I'm playing with you idea to remove the parent/child from the FromClause and introduce such a structure in the FromClauseProcessor. just a question, in the current implementation a fromClause can have more than one child fromClause , but I cannot figure out when this happen :( Thanks a

[hibernate-dev] Query Parser Redesign

2015-08-24 Thread Steve Ebersole
Andrea, this is in relation to something you asked me on IRC today. Specifically in regards to FromClause and the fact that it maintains pointers to parent/children. As I said on IRC there is no intrinsic need (I do not foresee) for keeping this structure; I really only did that because FromCauseP