Re: [hibernate-dev] Pull request

There are 100, but that's because some of them are for 4.x or 5.0, 5.1 or they lack Tets Cases or the user hasn't confirmed the CLA. We integrate most Pull Requests in a timely fashion. Vlad On Wed, Jun 7, 2017 at 6:08 PM, Sanne Grinovero wrote: > On 7 June 2017 at 15:46, Vlad Mihalcea wrote:

Re: [hibernate-dev] Pull request

On 7 June 2017 at 15:46, Vlad Mihalcea wrote: > Hi Sanne, > > The PR queue has not been neglected at all. The problem was that the issue > was still marked with the "Requires Changes" label, and I assumed it was not > done yet. Great to hear. Sorry, I just assumed it was the case as you've all be

Re: [hibernate-dev] Pull request

Hi Sanne, The PR queue has not been neglected at all. The problem was that the issue was still marked with the "Requires Changes" label, and I assumed it was not done yet. Vlad On Wed, Jun 7, 2017 at 12:41 PM, Sanne Grinovero wrote: > Hi Milo, > > apologies for that. The ORM team had some meet

Re: [hibernate-dev] Pull request

Vlad / Milo - I've got it on my todo list for today unless Vlad beats me to it :). Chris On 06/07/2017 12:09 AM, Vlad Mihalcea wrote: > Hi, > > If Chris is busy, I can review it for you. > > Vlad > > On Tue, Jun 6, 2017 at 10:36 PM, Milo van der Zee > wrote: > > H

Re: [hibernate-dev] Pull request

Hi Milo, apologies for that. The ORM team had some meetings, travelling, etc.. I guess the PR queue has been temporarily neglected and they'll have to catch up. I don't think you missed something, good idea to call for attention on the mailing list. Thanks, Sanne On 6 June 2017 at 20:36, Milo

Re: [hibernate-dev] Pull request

Hi, If Chris is busy, I can review it for you. Vlad On Tue, Jun 6, 2017 at 10:36 PM, Milo van der Zee wrote: > Hello, > > I submitted a pull request and fixed some issues with it (jUnit test and > formatting) and after that nothing happens. How does this work? Do I > just have to be patient or

[hibernate-dev] Pull request

Hello, I submitted a pull request and fixed some issues with it (jUnit test and formatting) and after that nothing happens. How does this work? Do I just have to be patient or do I miss something? https://github.com/hibernate/hibernate-orm/pull/1906 MAG, Milo _

Re: [hibernate-dev] Pull request for HHH-11089

Hi Petar, you can use Identifier#toIdentifier(String text) this method detects if the text is quoted and it calls the Identifier#toIdentifier( String text , boolean quoted ) with the correct quoted value. On 21 September 2016 at 16:54, Petar Tahchiev wrote: > Hey guys, > > I just created a

[hibernate-dev] Pull request for HHH-11089

Hey guys, I just created a pull-request for HHH-11089: https://github.com/hibernate/hibernate-orm/pull/1564 However when I create the Identifier like this: Identifier.toIdentifier( keyName, true ); I always set quoted to true as I don't know where to get this value from. Can someone please ha

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Saw that. Thanks! On Thu, Jul 12, 2012 at 5:18 PM, Steve Ebersole wrote: > It did make it into the 4.1.5.SP1 however :) > > > > On Thu 12 Jul 2012 08:52:43 AM CDT, Steve Ebersole wrote: > >> Rob, I apologize. This was missed in the 4.1.5 release. >> >> On Thu 28 Jun 2012 01:55:53 PM CDT, Steve

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

It did make it into the 4.1.5.SP1 however :) On Thu 12 Jul 2012 08:52:43 AM CDT, Steve Ebersole wrote: > Rob, I apologize. This was missed in the 4.1.5 release. > > On Thu 28 Jun 2012 01:55:53 PM CDT, Steve Ebersole wrote: >> The plan as of now is to not have a 4.2. >> >> Your changes will be in

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Rob, I apologize. This was missed in the 4.1.5 release. On Thu 28 Jun 2012 01:55:53 PM CDT, Steve Ebersole wrote: > The plan as of now is to not have a 4.2. > > Your changes will be in 4.1.5 (if ok). > > On Thu 28 Jun 2012 01:04:42 PM CDT, Rob Worsnop wrote: >> OK, done. I think I covered everyth

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

The plan as of now is to not have a 4.2. Your changes will be in 4.1.5 (if ok). On Thu 28 Jun 2012 01:04:42 PM CDT, Rob Worsnop wrote: > OK, done. I think I covered everything. > > Assuming my changes are OK, will they be in 4.2? > > On Mon, Jun 25, 2012 at 11:48 PM, Rob Worsnop

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

OK, done. I think I covered everything. Assuming my changes are OK, will they be in 4.2? On Mon, Jun 25, 2012 at 11:48 PM, Rob Worsnop wrote: > Oh good. The way I am coding it, the flag will be ignored > if SqlFragmentAlias elements are present. > > > On Mon, Jun 25, 2012 at 3:40 PM, Steve Eber

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Oh good. The way I am coding it, the flag will be ignored if SqlFragmentAlias elements are present. On Mon, Jun 25, 2012 at 3:40 PM, Steve Ebersole wrote: > And by the way, I think you are right in that if there are any explicit > SqlFragmentAlias bits supplied, that we infer 'deduceAliasInjecti

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Yep. Working on it. Regarding the name, my view is that most developers would need to read the doc whatever we call it. On Mon, Jun 25, 2012 at 3:36 PM, Steve Ebersole wrote: > Rob, were you willing to incorporate these discussed changes into your > pull request? > > Personally I think 'autoAli

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

And by the way, I think you are right in that if there are any explicit SqlFragmentAlias bits supplied, that we infer 'deduceAliasInjectionPoints' as being false. On 06/25/2012 08:29 AM, Rob Worsnop wrote: > Got it. Earlier you were looking for suggestions for a less verbose name > for this. How

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Rob, were you willing to incorporate these discussed changes into your pull request? Personally I think 'autoAliasInjection' is less telling than 'deduceAliasInjectionPoints'. I guess the question is whether it is still telling enough that users get a sense of what it means just by name. On

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Got it. Earlier you were looking for suggestions for a less verbose name for this. How about "autoAliasInjection"? On Mon, Jun 25, 2012 at 8:20 AM, Steve Ebersole wrote: > 'deduceAliasInjectionPoints' is important when you don't have injections. > Otherwise Hibernate ends up scanning the condit

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

'deduceAliasInjectionPoints' is important when you don't have injections. Otherwise Hibernate ends up scanning the condition fragment for no reason. On Fri 22 Jun 2012 11:09:31 AM CDT, Rob Worsnop wrote: > On Mon, Jun 4, 2012 at 12:14 PM, Steve Ebersole wrote: >> 1) I think adding support for

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

On Mon, Jun 4, 2012 at 12:14 PM, Steve Ebersole wrote: > 1) I think adding support for {alias} is a more general issue.  Its > applicable to many other pieces of mapping metadata (@Formula, etc).  More I > was responding to David's comment there.  I totally think it makes sense to > support this i

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

1) I think adding support for {alias} is a more general issue. Its applicable to many other pieces of mapping metadata (@Formula, etc). More I was responding to David's comment there. I totally think it makes sense to support this in all of those cases. I guess the vote point there is wheth

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Steve, Thanks for the feedback. Is this a correct summary: * Introduce the "{alias}" placeholder, as in Restrictions.sqlRestriction. * Introduce another optional @Filter element, "entity", which developers could use instead of the proposed "table" element. Thanks, Rob. On Fri, Jun 1, 2012 at 1

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

Hi Rob, overall I am OK with the proposal. Some comments inline On Thu 31 May 2012 03:32:25 PM CDT, David Mansfield wrote: >> It seemed that the challenge to overcome was that Hibernate did not >> know which aliases to use when generating the where clauses for >> filters. When filters are not a

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

I'm no hibernate guru, but I have some comments below: On 05/30/2012 05:42 PM, Rob Worsnop wrote: > https://github.com/hibernate/hibernate-orm/pull/339 > > It seemed that the challenge to overcome was that Hibernate did not > know which aliases to use when generating the where clauses for > filter

[hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

https://github.com/hibernate/hibernate-orm/pull/339 It seemed that the challenge to overcome was that Hibernate did not know which aliases to use when generating the where clauses for filters. When filters are not allowed on subclasses (current situation), the alias for the root entity is used for

Re: [hibernate-dev] Pull request

I think I just missed the notification from you comment and GitHub does not notify us when the code underlying a pull request has been updated. Thanks for following up. I'll get to it for 4.1 On Wed 25 Jan 2012 03:19:01 PM CST, Paweł Stawicki wrote: > Hello, > > Some time ago I issued a pull r

[hibernate-dev] Pull request

Hello, Some time ago I issued a pull request (https://github.com/hibernate/hibernate-orm/pull/243). There were some formatting problems, I fixed them. Now I'd like to know what next. It is still not merged, and there are no more comments. If it's ok, I'd love it to be merged. If it's not, I'd lov

Re: [hibernate-dev] Pull request for HHH-6865

I am working on this one. Was going to use the opportunity to clean up some things in the LockingStrategy hierarchy and its users. On Wed 30 Nov 2011 08:01:11 AM CST, Gail Badner wrote: > I created a pull request for HHH-6865. > > IMO, this should be fixed for the next CR. > > https://hibernate.

[hibernate-dev] Pull request for HHH-6865

I created a pull request for HHH-6865. IMO, this should be fixed for the next CR. https://hibernate.onjira.com/browse/HHH-6865 https://github.com/hibernate/hibernate-core/pull/232 Please take a look and merge if it looks OK. Thanks, Gail ___ hibernate

Re: [hibernate-dev] Pull request sent for HHH-3551

On Wed, Jan 12, 2011 at 5:27 AM, Sanne Grinovero wrote: > hi Laird, > sorry I just noticed that our thread fell of the mailing list, please > keep everyone in CC as I'm not the most expert on these aspects. > > Did you get any results? > Not yet. I'll keep you posted. L

Re: [hibernate-dev] Pull request sent for HHH-3551

hi Laird, sorry I just noticed that our thread fell of the mailing list, please keep everyone in CC as I'm not the most expert on these aspects. Did you get any results? Regards, Sanne 2011/1/6 Laird Nelson : > This page shows the available drivers: > > http://www14.software.ibm.com/webapp/downl

Re: [hibernate-dev] Pull request sent for HHH-3551

Hi Laird, thanks a lot for the patch. I can't merge your patch right away as we need to check bits about backwards compatibility; from the javadocs in InformixDialect I see this dialect was initially created using Informix JDBC driver version 2.21JC3: would it be possible for you to check if your p

Re: [hibernate-dev] Pull request sent for HHH-3551

Ah, sorry, I see that pull requests have their own URLs. Here is the URL to mine: https://github.com/hibernate/hibernate-core/pull/27 Thanks, and sorry again for the newbie incompetence. Best, Laird On Wed, Jan 5, 2011 at 1:30 PM, Laird Nelson wrote: > Not sure whether it is appropriate to no

[hibernate-dev] Pull request sent for HHH-3551

Not sure whether it is appropriate to note it here, but in the interest of transparency: as part of my campaign to get http://opensource.atlassian.com/projects/hibernate/browse/HHH-3551 reopened and fixed, I've sent a github pull request with a patch that fixes the problem. Please kindly advise if