On 26 nov. 09, at 10:59, Amin Mohammed-Coleman wrote:
> Hi
>
> So I'll make the following changes
>
> 1) Move fulltextfilterdef to a global settings, similar to the
> Analyzer definitions. This means that SearchFactoryImpl would need
> to be updated to check for not only entities for filter
Hi
So I'll make the following changes
1) Move fulltextfilterdef to a global settings, similar to the Analyzer
definitions. This means that SearchFactoryImpl would need to be updated to
check for not only entities for filter defs but also in the global settings?
2) Remove analyzerDescriminator f
On 26 nov. 09, at 09:32, Sanne Grinovero wrote:
> About 2)
> 2A - fullTextFilterDef:
> While it's ok for the annotation to stay on an indexed entity, I don't
> see a named filter as coupled/related to an entity, shouldn't this be
> part of global settings?
Ah right, makes sense
>
> 2B - analyze
Yes we need a factory somewhere but I don't know where yet.
On 26 nov. 09, at 09:56, Amin Mohammed-Coleman wrote:
> Hi
>
> Ive updated the ProvidedId mapping test to include the changes you
> made. Also added some more factory methods in the
> ContainedInMapping. On a side note, I've made S
Hi
Ive updated the ProvidedId mapping test to include the changes you made.
Also added some more factory methods in the ContainedInMapping. On a side
note, I've made SearchMapping an interface but wasn't sure how to create it,
is there a class I can use to construct a new search mapping? The
Sea
Hi
In relation to fullTextFilterDef, that was my initial thoughts but I noticed
that the full text filter definition (annotation) was built from an entity
in searchFactoryImpl
private void bindFilterDefs(XClass mappedXClass) {
FullTextFilterDef defAnn = mappedXClass.getAnnotation( FullTextFilte
About 2)
2A - fullTextFilterDef:
While it's ok for the annotation to stay on an indexed entity, I don't
see a named filter as coupled/related to an entity, shouldn't this be
part of global settings?
2B - analyzerDiscriminator
yes makes sense only on an indexed entity, not on indexedembeeded as
it'
Hey,
Let's release Beta1 as it is except for 5 and 6 and take time to try
the API before refining it.
On 25 nov. 09, at 17:29, Amin Mohammed-Coleman wrote:
> Hi All,
>
> Would it be possible get feedback with regards to points 2, 3 and
> 4. I can create patch to address those issues.
>
> Ch
Hi All,
Would it be possible get feedback with regards to points 2, 3 and 4. I can
create patch to address those issues.
Cheers
Amin
On Fri, Nov 20, 2009 at 2:20 PM, Emmanuel Bernard wrote:
> Hi Amin,
> I've committed your patch, thanks!
> There is still some work and questions remaining but
Hi Emmanuel,
Thanks. I'm working on the docs at the moment.
I've added some of my comments.
On Fri, Nov 20, 2009 at 2:21 PM, Emmanuel Bernard wrote:
>
> On 20 nov. 09, at 15:20, Emmanuel Bernard wrote:
>
> Hi Amin,
> I've committed your patch, thanks!
> There is still some work and questions r
On 20 nov. 09, at 15:20, Emmanuel Bernard wrote:
> Hi Amin,
> I've committed your patch, thanks!
> There is still some work and questions remaining but that's a big
> coverage improvement. Now on to the doc to get the release out :)
>
> Here is my raw feedback
>
> 1.
> Interface vs class?
> Sho
11 matches
Mail list logo
