Re: [hibernate-dev] Patch for HHH-272: Custom SQL for column gets and sets

2009-09-10 Thread Max Rydahl Andersen
thanks - I forgot the "insert sql literals into the insert/update/query sql" requirement :) /max Rob Hasselbaum wrote: On 09/07/2009 06:37 PM, Max Rydahl Andersen wrote: What is this doing that a parameterized custom type can't do ? Is this "just" to get a cleaner hbm.xml syntax or ? /max

Re: [hibernate-dev] Patch for HHH-272: Custom SQL for column gets and sets

2009-09-05 Thread Rob Hasselbaum
Steve, Any additional input before I upload a new patch? -Rob On 09/03/2009 10:28 PM, Rob Hasselbaum wrote: Hi Steve, Thanks for the feedback. I am working on moving the patch to trunk as you requested. I'll update the bug when that's done. My comments on the rest of your feedback are inli

Re: [hibernate-dev] Patch for HHH-272: Custom SQL for column gets and sets

2009-09-03 Thread Rob Hasselbaum
Hi Steve, Thanks for the feedback. I am working on moving the patch to trunk as you requested. I'll update the bug when that's done. My comments on the rest of your feedback are inline below. On 09/03/2009 04:39 PM, Steve Ebersole wrote: > 1) Personally, I don't like the attribute names sql-get

Re: [hibernate-dev] Patch for HHH-272: Custom SQL for column gets and sets

2009-09-03 Thread Steve Ebersole
1) Personally, I don't like the attribute names sql-get and sql-set. When I think through trying to describe and explain this feature to people, the terms "wrap" and "unwrap" keep coming to my head as being descriptive, relevant and natural. It was really the "naturalness" aspect that got me with

Re: [hibernate-dev] Patch for HHH-272: Custom SQL for column gets and sets

2009-09-02 Thread Steve Ebersole
Awesome! This is one of those things I always wanted to get implemented but it was always getting pushed down my priority list. Thanks for taking on that work. I'll definitely take a look this week. If you could work it up for trunk that would be better. New features should really not get adde

Re: [hibernate-dev] Patch for HHH-272: Custom SQL for column gets and sets

2009-09-02 Thread Rob Hasselbaum
On Wed, Sep 2, 2009 at 5:17 PM, Rob Hasselbaum wrote: > I've submitted a patch with unit tests for HHH-272 and I'm interested in > feedback. > Incidentally, only the "hhh-272-hbcore-patch.txt" file is relevant. The other attachments to the bug were added a long time ago by another developer, and

[hibernate-dev] Patch for HHH-272: Custom SQL for column gets and sets

2009-09-02 Thread Rob Hasselbaum
Hi, I've submitted a patch with unit tests for HHH-272 and I'm interested in feedback. The patch allows users to specify custom SQL get and set expressions for property columns. This can be used to call SQL functions or perform some other kind of database-side conversion without giving up automati