Re: [hibernate-dev] Oracle12cDialect identity support

2016-01-14 Thread Gail Badner
Just to bring everyone up-to-date, the following were fixed in Hibernate ORM 5.0.7: * HHH-10421: "native" ID generator for Oracle12cDialect changed to SequenceStyleGenerator; this change make the "native" ID generator for Oracle12cDialect consistent with earlier Oracle dialects; * HHH-10422: fix id

Re: [hibernate-dev] Oracle12cDialect identity support

2016-01-05 Thread Gail Badner
I was mistaken when I said that an IDENTITY ID will be created when using @GeneratedValue or @GeneratedValue(strategy= GenerationType.AUTO). With hibernate.id.new_generator_mappings set to true by default in 5.0 and 5.1, a SequenceStyleGenerator will be used instead. Currently, the default for "na

Re: [hibernate-dev] Oracle12cDialect identity support

2016-01-05 Thread Steve Ebersole
On Tue, Jan 5, 2016 at 12:42 AM Gail Badner wrote: > > >> Native is a Hibernate-only concept and so we can really choose whatever >> we want for native generators. Also native is an outdated concept, >> replaced by AUTO and SequenceStyleGenerator. IMO we should never be >> choosing IDENTITY fo

Re: [hibernate-dev] Oracle12cDialect identity support

2016-01-04 Thread Gail Badner
Please see below... On Sat, Dec 26, 2015 at 8:52 AM, Steve Ebersole wrote: > I'd prefer that IDENTITY never be the native generator any time we add a > new Dialect. > +1 > Native is a Hibernate-only concept and so we can really choose whatever > we want for native generators. Also native is

Re: [hibernate-dev] Oracle12cDialect identity support

2015-12-26 Thread Steve Ebersole
I'd prefer that IDENTITY never be the native generator any time we add a new Dialect. Native is a Hibernate-only concept and so we can really choose whatever we want for native generators. Also native is an outdated concept, replaced by AUTO and SequenceStyleGenerator. IMO we should never be cho

Re: [hibernate-dev] Oracle12cDialect identity support

2015-12-24 Thread Emmanuel Bernard
I think my preference would be to override in Oracle*Dialect getNativeIdentifierGeneratorClass so that it always returns SequenceStyleGenerator 1. it would be backward compatible with the logic we had for ever (with the exception of 5.0 but I understand that it is not really reliable) 2. I supp

[hibernate-dev] Oracle12cDialect identity support

2015-12-23 Thread Gail Badner
Oracle12cDialect was added in 5.0 by HHH-9044. Unfortunately there are problems with the new identity support that Oracle12cDialect introduced (HHH-9983). The fix for HHH-9983 involved SPI changes, so it was applied to master for 5.1 (only). A couple of weeks ago, Andrea found that identities seem