Re: [hibernate-dev] ORM 5.2 issue with getInterceptor() not being a true getter

2017-09-12 Thread Guillaume Smet
Thanks Gail! On Tue, Sep 12, 2017 at 8:10 AM, Gail Badner wrote: > I created https://hibernate.atlassian.net/browse/HHH-11982. > > I just committed the one-line change without a unit test. Unless I hear > otherwise, I'll assume that's OK and I'll plan to release on Wednesday, > 9/13. > > Regards

Re: [hibernate-dev] ORM 5.2 issue with getInterceptor() not being a true getter

2017-09-11 Thread Gail Badner
I created https://hibernate.atlassian.net/browse/HHH-11982. I just committed the one-line change without a unit test. Unless I hear otherwise, I'll assume that's OK and I'll plan to release on Wednesday, 9/13. Regards, Gail On Mon, Sep 11, 2017 at 10:52 PM, Gail Badner wrote: > OK, I'll fix it

Re: [hibernate-dev] ORM 5.2 issue with getInterceptor() not being a true getter

2017-09-11 Thread Gail Badner
OK, I'll fix it for 5.2.11. Thanks, Gail On Mon, Sep 11, 2017 at 12:20 PM, Steve Ebersole wrote: > I'm fine with that. That method really does not fit with the paradigm > which needs that pulse. > > > On Mon, Sep 11, 2017 at 1:36 PM Sanne Grinovero > wrote: > > > On 11 September 2017 at 16:14

Re: [hibernate-dev] ORM 5.2 issue with getInterceptor() not being a true getter

2017-09-11 Thread Steve Ebersole
I'm fine with that. That method really does not fit with the paradigm which needs that pulse. On Mon, Sep 11, 2017 at 1:36 PM Sanne Grinovero wrote: > On 11 September 2017 at 16:14, Guillaume Smet > wrote: > > Hi! > > > > Any comment on this? > > > > After reading the javadoc of SharedSession

Re: [hibernate-dev] ORM 5.2 issue with getInterceptor() not being a true getter

2017-09-11 Thread Sanne Grinovero
On 11 September 2017 at 16:14, Guillaume Smet wrote: > Hi! > > Any comment on this? > > After reading the javadoc of SharedSessionContractImplementor, I think we > should probably just get rid of the `checkTransactionSynchStatus();` call > in getInterceptor(). > > I don't think getInterceptor() sh

Re: [hibernate-dev] ORM 5.2 issue with getInterceptor() not being a true getter

2017-09-11 Thread Guillaume Smet
Hi! Any comment on this? After reading the javadoc of SharedSessionContractImplementor, I think we should probably just get rid of the `checkTransactionSynchStatus();` call in getInterceptor(). I don't think getInterceptor() should be responsible for joining the transaction. What do you all thi

[hibernate-dev] ORM 5.2 issue with getInterceptor() not being a true getter

2017-09-08 Thread Guillaume Smet
Hi, Note to Gail: this is potentially a blocking issue for 5.2.11 for the OGM upgrade (I thought it was a bug in OGM but apparently, it's an issue with ORM). In 5.2 SessionImpl, we now use getInterceptor() instead of accessing the interceptor field directly because the field has been moved to Abs