Re: [hibernate-dev] Not letting Jenkins auto-close PRs upon build failures

2016-01-11 Thread Sanne Grinovero
This is finally fixed. Had to upgrade the plugin too, let's keep an eye on it for other possible regressions. On 8 Jan 2016 14:56, "Gunnar Morling" wrote: > 2016-01-08 14:39 GMT+01:00 Sanne Grinovero : > > Do you have an example of such a PR being closed? > > Yes, https://github.com/hibernate/hib

Re: [hibernate-dev] Not letting Jenkins auto-close PRs upon build failures

2016-01-08 Thread Gunnar Morling
2016-01-08 14:39 GMT+01:00 Sanne Grinovero : > Do you have an example of such a PR being closed? Yes, https://github.com/hibernate/hibernate-ogm/pull/610 whose auto-closing half a dozen times nearly drove me nuts ;) > > For sure that was never our intention, but be aware that such options > can b

Re: [hibernate-dev] Not letting Jenkins auto-close PRs upon build failures

2016-01-08 Thread Sanne Grinovero
Do you have an example of such a PR being closed? For sure that was never our intention, but be aware that such options can be set globally on the ci server as project detaults, but can be overriden in a specific build task. So I'd check the build task which did this as for example Search PRs seem

Re: [hibernate-dev] Not letting Jenkins auto-close PRs upon build failures

2016-01-05 Thread Emmanuel Bernard
+1, but I don’t know how ;) > On 05 Jan 2016, at 13:55, Gunnar Morling wrote: > > Hi, > > Not sure whether that's a new behaviour, but it's super annoying that > the pull request builder automatically closes pull requests if there > is a build failure. Can we change this so the PR stays open, p

[hibernate-dev] Not letting Jenkins auto-close PRs upon build failures

2016-01-05 Thread Gunnar Morling
Hi, Not sure whether that's a new behaviour, but it's super annoying that the pull request builder automatically closes pull requests if there is a build failure. Can we change this so the PR stays open, please? The current behaviour is highly frustrating, you need to re-open the PR again after f