Re: [hibernate-dev] Negative sequence numbers

2017-04-27 Thread Gail Badner
I see that there are some OptimizerUnitTest tests failing. Please hold off on looking at the PR until I figure out what's going on. On Thu, Apr 27, 2017 at 5:46 PM, Gail Badner wrote: > Hi Steve, > > I'm finally getting back to this. > > The assertion you suggest fails for SequenceHiLoGeneratorN

Re: [hibernate-dev] Negative sequence numbers

2017-04-27 Thread Gail Badner
Hi Steve, I'm finally getting back to this. The assertion you suggest fails for SequenceHiLoGeneratorNoIncrementTest because the test specifically sets increment_size=0. [1] I'm assuming the legacy behavior should be preserved. Another strange thing -- in NoopOptimer#generate, when incrementSize

Re: [hibernate-dev] Negative sequence numbers

2017-04-19 Thread Steve Ebersole
See inline... On Tue, Apr 18, 2017 at 8:36 PM Gail Badner wrote: > Should Hibernate support negative sequence values? > Absolutely. Hibernate has historically supported decrementing and/or negative values - so yes that should continue to work. If so, is my proposed fix OK? > Define "OK" :)

[hibernate-dev] Negative sequence numbers

2017-04-18 Thread Gail Badner
I see a comment on HHH-10219 that sounds like negative sequence values are supported by NoopOptimizer [1], but it does not seem to work. I've pushed a test case to my fork [2] with an entity defined as: @Entity( name = "TheEntity" ) @Table( name = "TheEntity" ) public static class The