Re: [hibernate-dev] Jandex, scanning and discovery

2014-05-06 Thread Steve Ebersole
FYI, I created a Pull Request[1] to discuss these changes if anyone was interested. If not I'll apply this later in the week. The commits incorporate some other concepts such as some changes to "user directed logging" I discussed in hibernate-dev emails. I have added some line comments at import

Re: [hibernate-dev] Jandex, scanning and discovery

2014-04-30 Thread Steve Ebersole
I am contemplating something very drastic here. The back story is that we end up needing to index stuff from 2 places: the EntityManagerFactoryBuilder and again from MetadataBuildingProcess (part of Binder processing). The indexing from EntityManagerFactoryBuilder happens just during JPA bootstra

Re: [hibernate-dev] Jandex, scanning and discovery

2014-04-28 Thread Hardy Ferentschik
On 28 Jan 2014, at 17:20, Steve Ebersole wrote: > Almost done with this. We are much more aggressive about indexing stuff into > Jandex now (which is a good thing) when we are not handed a Jandex Index. > > However, this does mean we need to be more careful in the case of JPA and > exclude

Re: [hibernate-dev] Jandex, scanning and discovery

2014-04-28 Thread Steve Ebersole
Almost done with this. We are much more aggressive about indexing stuff into Jandex now (which is a good thing) when we are not handed a Jandex Index. However, this does mean we need to be more careful in the case of JPA and exclude-non-listed-classes. ATM we drive annotations based on Jandex (a

Re: [hibernate-dev] Jandex, scanning and discovery

2014-04-25 Thread Steve Ebersole
So here is what I propose more concretely... As a refresher, there are a few main characters: * Scanner - coordinates the scanning effort * PersistenceUnitDescriptor - provides access to needed PU information * ScanOptions - a few booleans to control processing within Scanner * ArchiveDescriptorFa

Re: [hibernate-dev] Jandex, scanning and discovery

2014-04-24 Thread Hardy Ferentschik
On 24 Jan 2014, at 23:25, Steve Ebersole wrote: > I'd like to suggest one change in scanning to support this as well. > Currently when the Scanner finds a Class, or package-info, etc it immediately > checks the "options" to see if this entry can be accepted (essentially > according to the PU

Re: [hibernate-dev] Jandex, scanning and discovery

2014-04-24 Thread Steve Ebersole
I have this working, but given the current scope of Scanner it is unfortunately of limited use. That is, currently it only works when using JPA boostrapping (technically, whenever you use the EntityManagerFactoryBuilder). Given how central we are making Jandex in this scheme, I think its worthwhi

Re: [hibernate-dev] Jandex, scanning and discovery

2014-04-21 Thread Hardy Ferentschik
On 21 Jan 2014, at 16:48, Steve Ebersole wrote: > As Brett finishes up the "unified schema" work I wanted to start discussion > about some simplifications that could/should come from that. I really like where all these work is going. I hope the unification will work > As I said, in the cases w

[hibernate-dev] Jandex, scanning and discovery

2014-04-21 Thread Steve Ebersole
As Brett finishes up the "unified schema" work I wanted to start discussion about some simplifications that could/should come from that. Jandex, scanning and discovery One of the outcomes of moving to Jandex to process annotations is the requirement that we have a good Jandex Index available to