Re: [hibernate-dev] HSEARCH-679 status

2011-04-04 Thread Tom Waterhouse
Sanne, 1) fixed - sequence of checking method interaction was incorrect, that has been fixed, along with a test to verify that indexing DOES occur as expected 2) fixed - the test was moved to org.hibernate.search.test.event. This required the registration of an extension of FullTextIndexEventLis

Re: [hibernate-dev] HSEARCH-679 status

2011-04-04 Thread Sanne Grinovero
Hi Tom, thank you, I'm playing with it right now. As I mentioned on JIRA, the main reason for which I didn't fix this yet is that my proposed solution is incomplete, I'm working on a real solution and a good test would help a lot. I'm having some problems with your code: 1) The test is always gr

Re: [hibernate-dev] HSEARCH-679 status

2011-04-04 Thread Tom Waterhouse
Sanne, I've added a comment to HSEARCH-679 that includes the instructions necessary to add the attached unit test to the hibernate-search code base. Let me know if you need anything more to check in the fix for HSEARCH-679. Tom On Tue, Mar 22, 2011 at 12:17 PM, Tom Waterhouse wrote: > Sanne, t

Re: [hibernate-dev] HSEARCH-679 status

2011-03-22 Thread Tom Waterhouse
Sanne, that testing strategy doesn't work unfortunately. The collection is loaded by virtue of creating test data, so it is intialized. I don't see how HSearch can be tested at the entity level. Perhaps a smaller unit test of FullIndexTextEventListener is the way to go instead. I'm not sure wha

Re: [hibernate-dev] HSEARCH-679 status

2011-03-22 Thread Sanne Grinovero
Hi Tom, sorry, copy paste error: I meant org.hibernate.collection.PersistentCollection, all collections retrieved from the database implement PersistentCollection, which exposes the wasInitialized() method. So just cast the collection to PersistentCollection and you should be able to check if it wa

Re: [hibernate-dev] HSEARCH-679 status

2011-03-22 Thread Tom Waterhouse
Sanne, I don't see the method you've identified in PersistentClass. The closest I could find to identifying if a property has been initialized is Hibernate.isPropertyInitialized(), but the method always returns true (object isn't a HibernateProxy, FieldInterceptionHelper.isInstrumented() returns

Re: [hibernate-dev] HSEARCH-679 status

2011-03-21 Thread Sanne Grinovero
2011/3/21 Tom Waterhouse : > Sanne, the unit test doesn't make any assertions, so I don't know how useful > it would be as a test.  It allows a user to view the Hibernate-generated > SQL, illustrating the entities loaded. Yes I saw that :) so I was asking if you could make a unit test out of it to

Re: [hibernate-dev] HSEARCH-679 status

2011-03-21 Thread Tom Waterhouse
Sanne, the unit test doesn't make any assertions, so I don't know how useful it would be as a test. It allows a user to view the Hibernate-generated SQL, illustrating the entities loaded. On Mon, Mar 21, 2011 at 2:46 PM, Sanne Grinovero wrote: > Hi Tom, > thanks for the reminder, you might have

Re: [hibernate-dev] HSEARCH-679 status

2011-03-21 Thread Sanne Grinovero
Hi Tom, thanks for the reminder, you might have noticed we're very busy lately, so thank you for your help proposal. I've just committed a solution draft on my HSEARCH-679 branch: https://github.com/Sanne/hibernate-search/tree/HSEARCH-679 It's a draft but seems to work; I still have to get someo

[hibernate-dev] HSEARCH-679 status

2011-03-21 Thread Tom Waterhouse
I see that HSEARCH-679 is scheduled to be released in Hibernate Search 3.4.0. I haven't seen any progress on the issue though. If it will help moving the issue along I can definitely test proposed solutions, we can reproduce the issue consistently. Unfortunately we've reproduced the issue during