And change the name of DefaultEntityEntryFactory :)
On Fri, Apr 17, 2015 at 2:04 PM, John O'Hara wrote:
> Thanks for reviewing, I was unsure of the best way to test if the Entity
> was referenced cached (or could be cached), I look at
> org.hibernate.persister.entity.EntityPersister#canUseRefer
Thanks for reviewing, I was unsure of the best way to test if the Entity
was referenced cached (or could be cached), I look at
org.hibernate.persister.entity.EntityPersister#canUseReferenceCacheEntries
instead.
Would it matter if the entity was Immutable and not cached? In that case
we would n
I commented on your pull request.
My main concern is how you determine "canClearEntityEntryReference". That
needs to change. See my comment.
On Mon, Apr 13, 2015 at 5:37 AM, John O'Hara wrote:
> I think there are two factors to consider, when the entity is marked as
> Immutable, and when t
I think there are two factors to consider, when the entity is marked as
Immutable, and when the EntityEntry can be shared between sessions.
Our use case concerns the ImmutableEntityEntry being cached and shared
between sessions, so we need to check if the Entity is reference cached
in the 2lc.
TBH, I have no idea what happens to comments on a Pull Request when you
squash and force push.
I'd just leave the multiple commits. We can squash them later.
On Tue, Apr 7, 2015 at 1:59 PM, John O'Hara wrote:
> Steve,
>
> I have made changes based on the github comments and your comments belo
Steve,
I have made changes based on the github comments and your comments below
(https://github.com/johnaoahra80/hibernate-orm/commits/HHH-9701).
Do you want me to squash the commits down to one? Not sure how this
would effect the comments you have already made on GH
Thanks
John
On 06/04/15
On Thu, Apr 2, 2015 at 4:45 AM, John O'Hara wrote:
> Steve,
>
> I have pushed a proposal for HHH-9701 to:
> https://github.com/johnaoahra80/hibernate-orm/tree/HHH-9701
>
> There are a couple of areas that I would appreciate feedback;
>
> 1) Serialization/Deserialization - EntityEntries implement
Steve,
I have pushed a proposal for HHH-9701 to:
https://github.com/johnaoahra80/hibernate-orm/tree/HHH-9701
There are a couple of areas that I would appreciate feedback;
1) Serialization/Deserialization - EntityEntries implementations can be
serialized and each implementation provide their ow
