Re: [hibernate-dev] HHH-2403 - import.sql improvement

2011-11-08 Thread Łukasz Antoniak
Pull request submitted: https://github.com/hibernate/hibernate-core/pull/211 Fill free to comment Steve :). Maybe introducing a new Service is not necessary. Anyway, it can be quickly removed. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org

Re: [hibernate-dev] HHH-2403 - import.sql improvement

2011-11-07 Thread Steve Ebersole
On Mon 07 Nov 2011 10:32:33 AM CST, Łukasz Antoniak wrote: > > The whole idea of supporting multiline statements is that users would > like to execute the scripts they already have (and for example execute > in SQL*Plus for production) without applying extra modifications. The > "continuation" symb

Re: [hibernate-dev] HHH-2403 - import.sql improvement

2011-11-07 Thread Łukasz Antoniak
Thanks Steve for your replay. The whole idea of supporting multiline statements is that users would like to execute the scripts they already have (and for example execute in SQL*Plus for production) without applying extra modifications. The "continuation" symbol/operator would be useless for them.

Re: [hibernate-dev] HHH-2403 - import.sql improvement

2011-11-07 Thread Steve Ebersole
No! That is not a good idea. It introduces unnecessary loss of backwards compatibility. Another option that is backwards compatible is to instead handle multi-line commands specially by introducing a "continuation" symbol/operator. Think `\` on *nix. The idea being that a line ending with

[hibernate-dev] HHH-2403 - import.sql improvement

2011-11-06 Thread Łukasz Antoniak
Welcome! Last time I have been trying to improve the way that Hibernate extracts statements from "import.sql" script. My intention was to support multiline SQL instructions (HHH-2403), quoted strings, multiline comments etc. After developing quite simple ANTLR-based parser, I have realized tha