So can you guys please review my pull request to asses whether this is the
best way to implement that change? Any comments are welcome.
On Fri, Nov 5, 2010 at 7:45 PM, Emmanuel Bernard wrote:
> Sorry, I had a off-line week, catching up here.
>
> I think we all agree the expected behavior (accordi
Sorry, I had a off-line week, catching up here.
I think we all agree the expected behavior (according to the spec) is that
EntityType.getName() should return @Entity.name.
I'd say for the future major rev, we should make the change.
I also think that the metamodel use at this stage is small enoug
Changing behaviors would be a good way to gauge that from the number of JIRA
issues created ;)
On Wednesday, November 03, 2010, at 10:36 am, Hardy Ferentschik wrote:
> If OpenJPA and EclipseLink went this way it makes sense to align. At least
> for Hibernate 4.
> I am also undecided whether to ba
Steve, I do believe we are on the same page and there is no disagreement at
all. I think you understand my argument clearly and I do understand your
concerns regarding users.
On Wed, Nov 3, 2010 at 4:49 PM, Steve Ebersole wrote:
> On Wednesday, November 03, 2010, at 11:33 am, Tomasz Blachowicz w
On Wednesday, November 03, 2010, at 11:33 am, Tomasz Blachowicz wrote:
> Steve, I think I know where you coming from. And my request is to do it
> *only* in the context of JPA meta-model. I'm far from making any changes to
> the internals of Hibernate.
> My pain point is that if EntityType is not p
If OpenJPA and EclipseLink went this way it makes sense to align. At least
for Hibernate 4.
I am also undecided whether to backport the issue or not. I tend rather
towards no, but without
any strong argument.
Whether and how EntityType.getName() is getting used I don't know.
Generally I woul
Steve, I think I know where you coming from. And my request is to do it
*only* in the context of JPA meta-model. I'm far from making any changes to
the internals of Hibernate.
My pain point is that if EntityType is not providing me with the
@Entity.name I don't have any other means of getting that
I completely empathize since the JPA "metamodel" defines no other means to get
at this information. I am however nervous especially nervous about
backporting this fix as it is a change in behavior that is far from clearly a
bug. I am kind of new to annotations so it is hard for me to say how/i
It's up to you. I put my arguments in the ticket. I agree that jsr317 spec
does not specify the correlation of the @Entity.name and
EntityType#getName(), but I do think it if reasonable to think that entity
name returned by the meta model and the entity name specified in the
annotation is the same
We were just discussing this on IRC. Yes I think adding a new attribute to
PersistentClass to capture the value of @Entity.name specifically (really we'd
just populate it with EntityBinder.name) is best.
So we know *how* to do it. But to be honest, I am still uncertain whether we
*should* do
You can have a look at my pull request to see exaclty what I mean.
https://github.com/hibernate/hibernate-core/pull/9 (two commits form that
branch)
On Wed, Nov 3, 2010 at 1:54 PM, Tomasz Blachowicz wrote:
> I think I understand what you mean. "Node name" might not be indeed the
> best way to do
I think I understand what you mean. "Node name" might not be indeed the best
way to do that.
I think implementation of the EntityBinder with regards to the handling of
@Entity.name is correct. My understanding of the jsr-317 is that the entity
name used in queries should be @Entity.name if specifi
Ah, I misread. I thought you meant the Hibernate notion of an "entity name".
As far as I can tell now looking at it, there is no such annotation equiv for
that.
@javax.persistence.Entity.name is really more akin to Hibernate's notion of an
import name for queries.
I am not really understan
If that is really the case, then that is a problem with the annotation binding
code.
On Wednesday, November 03, 2010, at 06:50 am, Tomasz Blachowicz wrote:
> Hi Steve,
>
> PersistentClass#getEntityName is not good, because it is exactly the same
> value as PersistentClass#getClassName.
> Persist
Hi Steve,
PersistentClass#getEntityName is not good, because it is exactly the same
value as PersistentClass#getClassName.
PersistentClass#getClassName is populated in
org.hibernate.cfg.annotations.EntityBinder#bindEntity with the value from
org.hibernate.annotations.common.reflection.java.JavaXCl
Uncertain yet of how these pull request comments work on GitHub, so I thought
I'll make sure and respond here. The change should use
org.hibernate.mapping.PersistentClass#getEntityName instead of
org.hibernate.mapping.PersistentClass#getNodeName.
See my other email to the dev list about portin
I've submitted the pull request (
https://github.com/hibernate/hibernate-core/pull/8) for master. I should
have it also ready for 3.6 branch as soon as I manage to merge the change
between branches in this git thng that is pretty new to me ;)
On Tue, Nov 2, 2010 at 1:18 PM, Emmanuel Bernard wrote:
Cool :)
If you use GitHub's infrastructure and use a pull-request, we can get that
integrated quite fast.
On 2 nov. 2010, at 13:50, Tomasz Blachowicz wrote:
> I've already created the ticket
> (http://opensource.atlassian.com/projects/hibernate/browse/HHH-5709).
> And I should be able to create
I've already created the ticket (
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5709).
And I should be able to create the patch sometime this evening.
Cheers,
Tom
On Tue, Nov 2, 2010 at 12:24 PM, Emmanuel Bernard wrote:
> I'd say you're correct and the name should match in the me
I'd say you're correct and the name should match in the metamodel.
Can you open a JIRA issue and even better try and work out a patch?
PS: I've spilled hot chocolate on my laptop in the past: not good, the machine
slowly but inevitably dies as corrosion wins it over.
On 2 nov. 2010, at 12:35, To
Hi,
I had been working recently on some stuff that deals with JPA2 meta model.
Hibernate is my JPA2 provider/engine. Everything works fine except one
little thing that is name of the Entity. I'd expect that value returned by
EntityType.getName() would be the same as @Entity.name but not the FQN of
21 matches
Mail list logo
