Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-31 Thread Guillaume Smet
OK, thanks, I'll submit a PR tomorrow. On Thu, Aug 31, 2017 at 6:21 PM, Steve Ebersole wrote: > Yes, I understand now. That is a good idea. > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hiberna

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-31 Thread Steve Ebersole
Yes, I understand now. That is a good idea. On Thu, Aug 31, 2017 at 11:20 AM Guillaume Smet wrote: > Steve, > > I think you misunderstood my point. Vlad got it. > > addEntity() is part of the NativeQuery API (and was moved to NativeQuery in > your 6 branch). > > It is marked as deprecated for o

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-31 Thread Guillaume Smet
Steve, I think you misunderstood my point. Vlad got it. addEntity() is part of the NativeQuery API (and was moved to NativeQuery in your 6 branch). It is marked as deprecated for our users because it is only present in SQLQuery which is marked as deprecated. I think the methods that will be kep

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-30 Thread Vlad Mihalcea
That's a good question. There are some methods which don't have a replacement in JPA so we should probably move to some subclass and remove the deprecated flag. Vlad On Wed, Aug 30, 2017 at 5:59 PM, Guillaume Smet wrote: > Hi, > > In OGM tests, we have a lot of warnings on this sort of constru

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-30 Thread Steve Ebersole
We have discussed this deprecation strategy ad nauseam. See any of the previous discussion on the dev list (as recent as just a few weeks ago) On Wed, Aug 30, 2017 at 11:39 AM Guillaume Smet wrote: > Hi, > > In OGM tests, we have a lot of warnings on this sort of constructs: > NativeQuery query

[hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-30 Thread Guillaume Smet
Hi, In OGM tests, we have a lot of warnings on this sort of constructs: NativeQuery query = session.createNativeQuery( nativeQuery ).addEntity( OscarWildePoem.class ); because addEntity() comes from SQLQuery and SQLQuery is deprecated. I don't think it's a good thing for our users as they have a