Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Guillaume Smet
On Wed, May 2, 2018 at 11:50 PM, Sanne Grinovero wrote: > On 2 May 2018 at 22:39, Guillaume Smet wrote: > > Hi Sanne, > > > > On Wed, May 2, 2018 at 11:24 PM, Sanne Grinovero > > wrote: > >> > >> > >> > >> javax.xml.bind > >> jaxb-api > >> provided > >> > >> > >> > >> com.su

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Christian Beikov
I actually think since the bootclasspath has precedence over the user classpath, nothing will happen. It's just that there is an additional JAR that needs to be downloaded. If it's an implementation with zero further dependencies, it might actually be an ok solution to add the dependency, as us

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Sanne Grinovero
On 2 May 2018 at 22:39, Guillaume Smet wrote: > Hi Sanne, > > On Wed, May 2, 2018 at 11:24 PM, Sanne Grinovero > wrote: >> >> >> >> javax.xml.bind >> jaxb-api >> provided >> >> >> >> com.sun.xml.bind >> jaxb-impl >> test >> > > > Not sure where you got these dependenc

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Guillaume Smet
On Wed, May 2, 2018 at 11:40 PM, Christian Beikov < christian.bei...@gmail.com> wrote: > People will have to adapt to this and add their own JAXB implementation, > just like they now use Hibernate as JPA implementation. > What happens if we add a strong dependency to a JAXB implementation in addi

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Christian Beikov
You are right that people will have to add some other dependencies if they want to use Hibernate on Java 9+, but IMO we should at least put the dependencies into the pom.xml that we have a hard dependency on which in this case is the jaxb-api or in module descriptor speak the "java.xml.bind" mo

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Guillaume Smet
Hi Sanne, On Wed, May 2, 2018 at 11:24 PM, Sanne Grinovero wrote: > > > > javax.xml.bind > jaxb-api > provided > > com.sun.xml.bind > jaxb-impl > test > > Not sure where you got these dependencies. I think the one we should use is the following: org.glassfish.jaxb

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Sanne Grinovero
On 2 May 2018 at 21:38, Marko Bekhta wrote: > Why not move to Stax as we've done in HV? It'll be more consistent this way. +1 that would be my preference, but it's longer term. It will require quite some more work - especially for Hibernate ORM. For now I'm wondering if we can be more helpful w

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Sanne Grinovero
On 2 May 2018 at 21:30, Christian Beikov wrote: > +1 for listing the API dependency "javax.xml.bind:jaxb-api". Not sure > about the implementation though, maybe we can use > "com.sun.xml.bind:jaxb-impl" as an optional dependency? Hi Christian, right that's what makes it confusing. We might want

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Marko Bekhta
Why not move to Stax as we've done in HV? It'll be more consistent this way. Have a nice day, Marko 2018-05-02 22:30 GMT+02:00 Christian Beikov : > +1 for listing the API dependency "javax.xml.bind:jaxb-api". Not sure > about the implementation though, maybe we can use > "com.sun.xml.bind:jaxb-i

Re: [hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Christian Beikov
+1 for listing the API dependency "javax.xml.bind:jaxb-api". Not sure about the implementation though, maybe we can use "com.sun.xml.bind:jaxb-impl" as an optional dependency? Mit freundlichen Grüßen, *Christian Beikov* Am

[hibernate-dev] Depending on JAXB / JDK11 compatibility

2018-05-02 Thread Sanne Grinovero
With JAXB being part of the JDK in Java 8, Hibernate ORM doesn't list it as a runtime dependency. Java 9 users have been suggested to use the JVM option "--add-modules java.xml.bind" to avoid the JVM hiding the JAXB library from classpath. With Java 11 the java.xml.bind is no longer available; wh