Re: [hibernate-dev] ConnectionObserver

2019-08-21 Thread Sanne Grinovero
Thanks all! Will incorporate these changes in my upcoming perfomance PR. On Wed, 21 Aug 2019 at 19:30, Steve Ebersole wrote: > > I'm fine with deprecating and removing. > > WRT changing `List` to just `ConnectionObserver` rather > we'd want to change it to `ConnectionObserverStatsBridge` to avo

Re: [hibernate-dev] ConnectionObserver

2019-08-21 Thread Steve Ebersole
I'm fine with deprecating and removing. WRT changing `List` to just `ConnectionObserver` rather we'd want to change it to `ConnectionObserverStatsBridge` to avoid the polymorphic call overhead. But otherwise I agree with everything On Tue, Aug 20, 2019 at 3:51 PM Gail Badner wrote: > In 4.2 an

Re: [hibernate-dev] ConnectionObserver

2019-08-20 Thread Gail Badner
In 4.2 and 4.3, it was possible to add a ConnectionObserver using org.hibernate.engine.jdbc.spi.LogicalConnectionImplementor#addObserver(ConnectionObserver observer). Starting in 5.0, LogicalConnectionImplementor was moved to org.hibernate.resource.jdbc.spi, and it's no longer possible to add a C

[hibernate-dev] ConnectionObserver

2019-08-20 Thread Sanne Grinovero
While refactoring some related optimisations, I noticed there's currently no way to register a custom ConnectionObserver. There seems to be only one implementation, which is registered by default: - org.hibernate.internal.ConnectionObserverStatsBridge#ConnectionObserverStatsBridge Some question