Re: [hibernate-dev] Checkstyle breaking the OGM build

2013-05-03 Thread Gunnar Morling
Ah, it may then be that you have to re-normalize the line endings in your existing checkout as described in [1]: git rm --cached -r .# Remove everything from the index. git reset --hard# Write both the index and working directory from git's database. [1] https://help.github.com/articles/d

Re: [hibernate-dev] Checkstyle breaking the OGM build

2013-05-03 Thread Guillaume SCHEIBEL
Did you get the latest patch (added by Davide) to fix the endofline issue ? 2013/5/3 Emmanuel Bernard > I found the problem, not sure where that comes from though. > > On a fresh repo clone it works as expected. So I did diff the two and > found that the failing version has lines ending as CRLF

Re: [hibernate-dev] Checkstyle breaking the OGM build

2013-05-03 Thread Emmanuel Bernard
I found the problem, not sure where that comes from though. On a fresh repo clone it works as expected. So I did diff the two and found that the failing version has lines ending as CRLF (Windows) and the fresh repo has lines ending as LF (Unix). On Fri 2013-05-03 8:32, Gunnar Morling wrote: > Wo

Re: [hibernate-dev] Checkstyle breaking the OGM build

2013-05-02 Thread Gunnar Morling
Works for me on my Mac as expected, i.e. I get the violation only when I really add another new line. > I'm wondering if we really want to keep this rule Personally I like the rule, several empty lines always look a bit odd to me. But if the check can't be executed reliably, it's surely not big l

Re: [hibernate-dev] Checkstyle breaking the OGM build

2013-05-02 Thread Sanne Grinovero
Can't reproduce this either. I'm wondering if we really want to keep this rule: its benefit is limited and even before this case we had trouble with it on windows. On 2 May 2013 23:41, "Guillaume SCHEIBEL" wrote: > Hi Emmanuel, > > Sorry I can't reproduce it and both maven & intellij plugins are

Re: [hibernate-dev] Checkstyle breaking the OGM build

2013-05-02 Thread Guillaume SCHEIBEL
Hi Emmanuel, Sorry I can't reproduce it and both maven & intellij plugins are telling me the Label class respects the rules. Guillaume 2013/5/3 Emmanuel Bernard > Taking OGM master, I get a checkstyle failure on one of the test file. > But what is surprising is that I don't see new lines at t

[hibernate-dev] Checkstyle breaking the OGM build

2013-05-02 Thread Emmanuel Bernard
Taking OGM master, I get a checkstyle failure on one of the test file. But what is surprising is that I don't see new lines at the end of the described file. Can you guys reproduce? Emmanuel [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hibernate-ogm-core --- [debug] exec