The patch seems to work but we are not sure what happens when you create a
new file in Windows,
We also didn't test it with a Mac.
In the meanwhile, I have created a patch that uses regular expressions
only. Could you test it and let me know if it works on Windows?
It would be nice if someone coul
So far so good, for the maven build I have added 2 things:
- **/target/generated-sources/*.java into the
hibernate-ogm-parent checkstyle plugin conf, to avoid the check of the
generated classes
- to the checkstyle config
(module NewlineAtEndOfFile) otherwise, each file had an issue about newline
2013/4/19 Sanne Grinovero
> +1
> next on my wishlist, and was already chatting about it with Steve the
> other days. You guys should not hide from IRC :-P
> I won't be able to do it now, but feel free to add the repository,
> package name and necessary configuration changes in the
> ci.hibernate.
+1
next on my wishlist, and was already chatting about it with Steve the
other days. You guys should not hide from IRC :-P
I won't be able to do it now, but feel free to add the repository,
package name and necessary configuration changes in the
ci.hibernate.org repository so that it gets auto-inst
Sonar is great. I am running it locally to get the metrics. That's the part I
am missing for HV on Cloudbees. Unfortunately, it is not included in the free
offering.
--hardy
On 19 Apr 2013, at 11:24, Strong Liu wrote:
> btw, what do you guys think of sonar?
>
> shall we give it a try on
btw, what do you guys think of sonar?
shall we give it a try on ci.hibernate.org?
On Apr 19, 2013, at 4:32 PM, Hardy Ferentschik wrote:
>
> On 19 Jan 2013, at 9:54 AM, Guillaume SCHEIBEL
> wrote:
>
>> Where can I find the new style rule for Intellij and the checktyle plugin ?
>
> I think
On 19 Jan 2013, at 9:54 AM, Guillaume SCHEIBEL
wrote:
> Where can I find the new style rule for Intellij and the checktyle plugin ?
I think the existing style rules have not changed. See also
https://community.jboss.org/wiki/ContributingtoHibernateSearch#Idea
It is just that we enforce the ru
Hi guys,
Where can I find the new style rule for Intellij and the checktyle plugin ?
As you know I'm a master to mess up with code formatting ;)
Thanks
Guilllaume
2013/4/18 Strong Liu
> btw, I just installed the checkstyle and findbugs plugin on our CI server
> :D
>
>
> On Apr 19, 2013, at
btw, I just installed the checkstyle and findbugs plugin on our CI server :D
On Apr 19, 2013, at 12:44 AM, Steve Ebersole wrote:
> IDEA has a checkstyle plugin (and a jdepend plugin fwiw). And it will
> also immediately show violations in the editor (as well as collect them
> in the problems
IDEA has a checkstyle plugin (and a jdepend plugin fwiw). And it will
also immediately show violations in the editor (as well as collect them
in the problems window). It does not auto detect the settings however,
you need to point it to the file.
You can still compile, run tests, etc. Very i
On 18 Jan 2013, at 6:15 PM, Sanne Grinovero wrote:
> On 18 April 2013 17:12, Davide D'Alto wrote:
>> I don't have any particular objection to set it on the verify phase. I tend
>> to always use mvn install anyway.
>>
>> The argument I can use to promote the compile phase (for sake of discussio
On 18 April 2013 17:12, Davide D'Alto wrote:
> I don't have any particular objection to set it on the verify phase. I tend
> to always use mvn install anyway.
>
> The argument I can use to promote the compile phase (for sake of discussion
> only)
> I like the fact that I can check the code writing
I don't have any particular objection to set it on the verify phase. I tend
to always use mvn install anyway.
The argument I can use to promote the compile phase (for sake of discussion
only)
I like the fact that I can check the code writing mvn compile, therefore
without starting any test.
If you
On 18 April 2013 16:56, Gunnar Morling wrote:
> Also you're not always in your IDE. For instance I recently tried to change
> something experimentally in the AS code base, just using my text editor (no,
> it was not vi ;). Then CS can really be in the way for compilation/tests. So
> I think it mak
Also you're not always in your IDE. For instance I recently tried to change
something experimentally in the AS code base, just using my text editor
(no, it was not vi ;). Then CS can really be in the way for
compilation/tests. So I think it makes most sense to have it in the
"verify" phase.
2013/
On 18 Jan 2013, at 5:27 PM, Sanne Grinovero wrote:
> On 18 April 2013 16:13, Gunnar Morling wrote:
>> Yeah, I was just about to suggest that :)
>
> Good idea, but isn't it true that if your IDE is correctly setup it doesn't
> matter?
True, but sometimes you might want to ignore the rules.
On 18 April 2013 16:13, Gunnar Morling wrote:
> Yeah, I was just about to suggest that :)
Good idea, but isn't it true that if your IDE is correctly setup it
doesn't matter?
I'm not sure about IDEA, but Eclipse detects the checkstyle rules and
shows violations right away.
> 2013/4/18 Hardy Fere
Yeah, I was just about to suggest that :)
2013/4/18 Hardy Ferentschik
>
> On 18 Jan 2013, at 4:48 PM, Sanne Grinovero wrote:
>
> > Hi all,
> >
> > yesterday we merged checkstyle integration in Hibernate OGM: it's
> > going to fail the compile phase if there are violations (!).
>
> +1 Joining t
On 18 Jan 2013, at 4:48 PM, Sanne Grinovero wrote:
> Hi all,
>
> yesterday we merged checkstyle integration in Hibernate OGM: it's
> going to fail the compile phase if there are violations (!).
+1 Joining the ranks of Validator and Search :-)
Btw, in HV Gunnar convinced me to attache the chec
On 18 April 2013 15:51, Steve Ebersole wrote:
> Nice!
>
> Curious how you got checkstyle to validate that tabs are used for indent?
Davide created this regex:
https://github.com/hibernate/hibernate-ogm/blob/master/src/main/build-config/checkstyle.xml#L36
Sanne
>
> On Apr 18, 2013 9:49 AM, "San
Nice!
Curious how you got checkstyle to validate that tabs are used for indent?
On Apr 18, 2013 9:49 AM, "Sanne Grinovero" wrote:
> Hi all,
>
> yesterday we merged checkstyle integration in Hibernate OGM: it's
> going to fail the compile phase if there are violations (!).
>
> By doing so, we als
Hi all,
yesterday we merged checkstyle integration in Hibernate OGM: it's
going to fail the compile phase if there are violations (!).
By doing so, we also had to re-style a large portion of code, as
surprisingly even though I though we where very careful on style and
whitespace inspections, huma
22 matches
Mail list logo
