Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-27 Thread Gail Badner
rom: "Gunnar Morling" > To: "Gail Badner" > Cc: "Gunnar Morling" , hibernate-dev@lists.jboss.org, > "Steve Ebersole" > Sent: Monday, May 26, 2014 1:07:10 AM > Subject: Re: [hibernate-dev] Changing method signatures in micro releases > > 2

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-26 Thread Gunnar Morling
(PersistentCollection, > > Serializable, int, SessionImplementor) > > > > Steve, I'm not 100% I did the right thing for HHH-9204 and HHH-9205, so > > please take a look at the pull request: > > https://github.com/hibernate/hibernate-orm/pull/747 > &g

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-23 Thread Gail Badner
bernate-dev@lists.jboss.org > Sent: Monday, May 19, 2014 3:16:56 PM > Subject: Re: [hibernate-dev] Changing method signatures in micro releases > > It was a simple matter to restore the old the method and provide a default > implementation of the method added by HHH-9078. > >

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-20 Thread Gunnar Morling
Gail, Steve, Thanks for your replies. 2014-05-20 15:28 GMT+02:00 Steve Ebersole : > We do strive to maintain backwards compatibility of SPIs. That being > said, there are times when fixing a bug requires a new SPI method. Which > *seems* to have been the case here. > That's good news. In you

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-20 Thread Steve Ebersole
We do strive to maintain backwards compatibility of SPIs. That being said, there are times when fixing a bug requires a new SPI method. Which *seems* to have been the case here. First, I am not sure what you mean by OGM "naturally still override the old signature". What "old signature"? This i

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-20 Thread Steve Ebersole
x27;ll let you know what I find. > > Regards, > Gail > > - Original Message - > > From: "Gunnar Morling" > > To: hibernate-dev@lists.jboss.org > > Sent: Monday, May 19, 2014 12:28:38 AM > > Subject: [hibernate-dev] Changing method signatures in micro r

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-19 Thread Gail Badner
> To: "Gunnar Morling" > Cc: hibernate-dev@lists.jboss.org > Sent: Monday, May 19, 2014 12:34:09 PM > Subject: Re: [hibernate-dev] Changing method signatures in micro releases > > Hi Gunnar, > > Thanks for mentioning this. I believe that org.hibernate.persister.colle

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-19 Thread Gail Badner
- Original Message - > From: "Gunnar Morling" > To: hibernate-dev@lists.jboss.org > Sent: Monday, May 19, 2014 12:28:38 AM > Subject: [hibernate-dev] Changing method signatures in micro releases > > Hi, > > When updating Hibernate OGM to make use of ORM 4.3.

[hibernate-dev] Changing method signatures in micro releases

2014-05-19 Thread Gunnar Morling
Hi, When updating Hibernate OGM to make use of ORM 4.3.5, I noticed a changed method signature in AbstractCollectionPersister (abstract method doProcessQueuedOps() has a new parameter). This causes a compilation failure in OGM, as we naturally still override the old signature. I can solve this pa