Re: [hibernate-dev] Changes around transaction -> changed exception behavior

2015-04-29 Thread Steve Ebersole
https://hibernate.atlassian.net/browse/HHH-9760 On Wed, Apr 29, 2015 at 8:21 AM, Steve Ebersole wrote: > Yes, I think that logic is not correct. A bigger concern I have there tbh > is HEM; there is some very fragile (at best) code that tries to "decode" > the exceptions thrown by the native API

Re: [hibernate-dev] Changes around transaction -> changed exception behavior

2015-04-29 Thread Steve Ebersole
Yes, I think that logic is not correct. A bigger concern I have there tbh is HEM; there is some very fragile (at best) code that tries to "decode" the exceptions thrown by the native APIs. That stuff could very easily break. On Tue, Apr 28, 2015 at 4:32 PM, Gunnar Morling wrote: > TransactionI

Re: [hibernate-dev] Changes around transaction -> changed exception behavior

2015-04-28 Thread Gunnar Morling
TransactionImpl#commit(); The before-completion code is now invoked through transactionDriverControl.commit(); whereas previously this happened out of a try/catch block. 2015-04-28 23:26 GMT+02:00 Steve Ebersole : > Where does that wrapping happen? > > On Tue, Apr 28, 2015 at 3:53 PM, Gunnar Morl

Re: [hibernate-dev] Changes around transaction -> changed exception behavior

2015-04-28 Thread Steve Ebersole
Where does that wrapping happen? On Tue, Apr 28, 2015 at 3:53 PM, Gunnar Morling wrote: > Hi, > > while working on making OGM work with ORM 5, I noticed a slightly different > behaviour wrt. to exceptions occurring during flushes. > > Previously, such exceptions would bubble up as is, whereas n

[hibernate-dev] Changes around transaction -> changed exception behavior

2015-04-28 Thread Gunnar Morling
Hi, while working on making OGM work with ORM 5, I noticed a slightly different behaviour wrt. to exceptions occurring during flushes. Previously, such exceptions would bubble up as is, whereas now the beforeTransactionCompletion() logic is called in a try/catch block, wrapping any exceptions in