Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Steve Ebersole
Per the discussion Luis and I had on IRC we will go with the prefix "hibernate.enhancer..". "enhancer" makes it more than clear what the intended target is. On Fri, Dec 4, 2015 at 4:50 AM Sanne Grinovero wrote: > Hi Luis, > thanks for this proposal, I was looking forward to see more > improvem

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Luis Barreiro
I think that document only landed on 5.1 because lazy groups is 5.1 only. Docs for 5.0 (and these are just on how to use the build-time plugins) are in a different place: documentation/src/main/asciidoc/topical/bytecode/BytecodeEnhancement.adoc On 12/04/2015 12:58 PM, Steve Ebersole wrote: > Lu

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Steve Ebersole
Luis, I am trying to remember if there is any reason I only added this to master (5.1). Was there a reason to not add it to 5.0 as well? Aside from the parts about lazy groups that is :) On Fri, Dec 4, 2015 at 6:28 AM Steve Ebersole wrote: > On Fri, Dec 4, 2015 at 5:43 AM Steve Ebersole wrot

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Sanne Grinovero
On 4 December 2015 at 12:32, Vlad Mihalcea wrote: > I investigated this issue: > > On master it's all fine: > > > > > > > > > but the 5.0.5 tag didn't declare the Bytecode chapter: > > > > > > > > > Vlad That's great, thanks! Now I might play with it too :) Sa

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Vlad Mihalcea
I investigated this issue: On master it's all fine: but the 5.0.5 tag didn't declare the Bytecode chapter: Vlad On Fri, Dec 4, 2015 at 1:43 PM, Steve Ebersole wrote: > On Fri, Dec 4, 2015 at 4:50 AM Sanne Grinovero > wrote: > > > Hi Luis, > > thanks for

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Steve Ebersole
On Fri, Dec 4, 2015 at 5:43 AM Steve Ebersole wrote: > Hm, there is a problem in the doc generation apparently :( For some > reason this chapter is not pulled in > https://github.com/hibernate/hibernate-orm/blob/master/documentation/src/main/docbook/userGuide/en-US/chapters/enhancement/BytecodeE

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Steve Ebersole
This all sounds good to me. For runtime enhancement I am ok with deprecating that setting, as long as in the meantime until its removal we continue to treat it as enabling all the enhancement features in addition to logging that warning. On Fri, Dec 4, 2015 at 12:29 AM Luis Barreiro wrote: > Hi

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Steve Ebersole
On Fri, Dec 4, 2015 at 4:50 AM Sanne Grinovero wrote: > Hi Luis, > thanks for this proposal, I was looking forward to see more > improvements in the area. > > Adding more properties sounds good to me, although I'd not use the > prefix "hibernate.enhance" as it sounds like it's about enhancing > H

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Sanne Grinovero
Hi Luis, thanks for this proposal, I was looking forward to see more improvements in the area. Adding more properties sounds good to me, although I'd not use the prefix "hibernate.enhance" as it sounds like it's about enhancing Hibernate - which might be true but one could say the same with many o

Re: [hibernate-dev] Bytecode enhancement configuration

2015-12-04 Thread Vlad Mihalcea
I like the idea of having multiple properties to enable a particular bytecode enhancement feature. It could be that the clients want to speed-up dirty checking but they don't really use the lazy initialization. Vlad On Fri, Dec 4, 2015 at 8:29 AM, Luis Barreiro wrote: > Hi all, > > I would like

[hibernate-dev] Bytecode enhancement configuration

2015-12-03 Thread Luis Barreiro
Hi all, I would like to start a discussion to know what is the general opinion about $subject, triggered by HHH- 10356. I'm also taking the opportunity to hear about some considerations I have on the configuration of the build-time plugins. * ** **- Run time* Right now it is not possible t