Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Emmanuel Bernard
FieldBridge#set(String name, Object value, Document document, LuceneOptions luceneOptions) On 4 déc. 09, at 16:46, Sanne Grinovero wrote: > It's only being used by the String2FieldBridgeAdaptor ? So boosting on > other types is ignored? ___ hibernat

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Emmanuel Bernard
On 4 déc. 09, at 16:51, Hardy Ferentschik wrote: > > On Fri, 04 Dec 2009 12:35:51 -0300, Emmanuel Bernard > wrote: > >> But then, would it make sense to reuse @Boost instead of a separated >> annotation as it is today? > > The main reason for using an explicit @Dynamic boost was to be more > exp

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Hardy Ferentschik
On Fri, 04 Dec 2009 12:35:51 -0300, Emmanuel Bernard wrote: > But then, would it make sense to reuse @Boost instead of a separated > annotation as it is today? The main reason for using an explicit @Dynamic boost was to be more explicit. Using @Boost means we need to add another parameter 'bo

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Sanne Grinovero
Ah yes thanks I found it. It's only being used by the String2FieldBridgeAdaptor ? So boosting on other types is ignored? Yes embedding the functonality in existing @Boost was something we had proposed on mailing list, but it probably didn't got much attention. What I recall is something like this

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Emmanuel Bernard
The altered boost is passed to the bridge as one of the LuceneOptions. On 4 déc. 09, at 16:36, Sanne Grinovero wrote: > Hardy, > I don't think setting @DynamicBoost on a field will affect the score > of that field, but rather receive that object as a parameter for the > function and affect the wh

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Sanne Grinovero
Hardy, I don't think setting @DynamicBoost on a field will affect the score of that field, but rather receive that object as a parameter for the function and affect the whole document scoring. That's about the current implementation; I'm still unsure that's possible to do differently. 2009/12/4 Ha

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Emmanuel Bernard
On 4 déc. 09, at 16:33, Emmanuel Bernard wrote: > > On 4 déc. 09, at 16:23, Hardy Ferentschik wrote: > >> One thing we have not done though is to add @DynamicBoost to @Field. >> Right now you can only >> specify @DynamicBoost directly on a field and the dynamic boost will >> apply to all @Field a

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Emmanuel Bernard
On 4 déc. 09, at 16:23, Hardy Ferentschik wrote: > One thing we have not done though is to add @DynamicBoost to @Field. > Right now you can only > specify @DynamicBoost directly on a field and the dynamic boost will > apply to all @Field annotations defined > on this field. Yes that would so

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Emmanuel Bernard
I'm pretty sure you can, we do dynamic boosting like a regular @Boost On 4 déc. 09, at 15:04, Sanne Grinovero wrote: > Is that possible? > I couldn't find the method in Lucene to boost per field, I've only > looked briefly into 2.9.1. > The BoostStrategy we had defined is only considered at index

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Hardy Ferentschik
Hi, I am not quite sure I follow. Why fieldname? And do you mean Lucene Document field name or a entity field name? I think originally we discussed defineBoost(String fieldName, Object value), but decided that the fieldName parameter was not needed. You can place the @DynamicBoost annotation

Re: [hibernate-dev] BoostStrategy issues

2009-12-04 Thread Sanne Grinovero
Is that possible? I couldn't find the method in Lucene to boost per field, I've only looked briefly into 2.9.1. The BoostStrategy we had defined is only considered at indexing time, are you thinking about a query time boosting? Would be nice to consider this for the QueryBuilder. Regards, Sanne

[hibernate-dev] BoostStrategy issues

2009-12-04 Thread Emmanuel Bernard
I think the BoostStrategy interface is not right. You can't adjust the boost strategy according to the field name and I think that's important (assuming dynamic boosting is used). We probably should rework it to do interface BoostStrategy { void defineBoost(String fieldName, Object value); }