Re: [hibernate-dev] Auto quoting of keywords used as identifiers

2015-05-01 Thread Sanne Grinovero
Right you could have the Dialects return the standard set by default, then someone with specialistic knowledge of the specific database could either override that with a custom Dialect or provide an improvement patch. I guess it's wise to not ignore the "extra keywords" defined by the driver, but

Re: [hibernate-dev] Auto quoting of keywords used as identifiers

2015-05-01 Thread Steve Ebersole
I understand what you are saying, in principle. Then there is the practical side. Personally I am not so interested in doing all the investigation over each Dialect to determine their exact set of keywords (A LOT of work), not to mention typing all that up (A LOT of duplication). Of course, if s

Re: [hibernate-dev] Auto quoting of keywords used as identifiers

2015-05-01 Thread Sanne Grinovero
Rather than basing our decisions on standards, wouldn't it be more useful to base it on *exactly* what the used database requires? In other words, why wouldn't it suffice to have a single source of keywords: the Dialect. --Sanne On 1 May 2015 at 15:19, Steve Ebersole wrote: > Interestingly, y

Re: [hibernate-dev] Auto quoting of keywords used as identifiers

2015-05-01 Thread Steve Ebersole
Interestingly, your IRC ping asked about KEY which in fact is *not* a SQL:2003 keyword. It had been a keyword in 92 and 99 SQL standards, but was removed in 2003. Which actually opens up an another interesting discussion as far as how aggressive to be in terms of affirming an identifier as being

[hibernate-dev] Auto quoting of keywords used as identifiers

2015-05-01 Thread Steve Ebersole
Gail, I saw your ping on IRC and thought it made sense to address here, since you were not around on IRC anymore. Overall, starting with 5.0, the idea is for Hibernate to automatically quote any identifiers is recognizes as a keyword. This is all encapsulated within the org.hibernate.engine.jdbc.