Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Steve Ebersole
Definitely. Thanks for doing this On Thu, Mar 22, 2018, 3:25 PM Gail Badner wrote: > I'm happy to see all the progress on this while I've been occupied with > 5.1.13 and some other urgent issues. > > I hope to have time to get caught up on things later today or tomorrow. > > On Thu, Mar 22, 20

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Gail Badner
I'm happy to see all the progress on this while I've been occupied with 5.1.13 and some other urgent issues. I hope to have time to get caught up on things later today or tomorrow. On Thu, Mar 22, 2018 at 10:55 AM, Gunnar Morling wrote: > I've mostly used Japicmp recently http://siom79.github.i

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Gunnar Morling
I've mostly used Japicmp recently http://siom79.github.io/japicmp/). Works pretty well, but it lacks a way to distinguish between API and SPI, so you'll likely also see "false positives". In fact I thought it's the one you'd be using, but it doesn't seem so from looking at the report attached to th

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Guillaume Smet
On Thu, Mar 22, 2018 at 4:20 PM, Sanne Grinovero wrote: > To make sure all the noise form "false positives" won't get us to miss > something, someone knows an alternative tool which can do better? > We use this one for HV https://github.com/siom79/japicmp . Not sure it's better though. If not,

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Steve Ebersole
I just pushed the first round of fixes for this upstream. On Thu, Mar 22, 2018 at 11:00 AM Sanne Grinovero wrote: > On 22 March 2018 at 15:55, David Lloyd wrote: > > This tool is usually pretty good; in fact I think it likely that it's > > the best of its kind. The false positives are really a

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Sanne Grinovero
On 22 March 2018 at 15:55, David Lloyd wrote: > This tool is usually pretty good; in fact I think it likely that it's > the best of its kind. The false positives are really a fairly recent > development AFAIK; I don't recall hitting any when I ran it for our > EJB changes a year or two ago. It m

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread David Lloyd
This tool is usually pretty good; in fact I think it likely that it's the best of its kind. The false positives are really a fairly recent development AFAIK; I don't recall hitting any when I ran it for our EJB changes a year or two ago. It might be a good idea to contribute a fix for the problem

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Steve Ebersole
Not sure. animal-sniffer is the other one I know, but not sure it would be better. On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero wrote: > To make sure all the noise form "false positives" won't get us to miss > something, someone knows an alternative tool which can do better? > > Thanks, > S

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Sanne Grinovero
To make sure all the noise form "false positives" won't get us to miss something, someone knows an alternative tool which can do better? Thanks, Sanne On 22 March 2018 at 14:22, Steve Ebersole wrote: > Yes there were "lots of differences" but a vast majority of them are > false-positives, not j

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-22 Thread Steve Ebersole
Yes there were "lots of differences" but a vast majority of them are false-positives, not just those listed in the already massive "false positives" section. I've been going through the non-"false positive" section and "resolving" specific items (via strike-through) with either (1) link to Jira fi

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-16 Thread Sanne Grinovero
Thanks Gail, great job! I fixed a trivial one, just a thousand to go ;) On 16 March 2018 at 23:09, Gail Badner wrote: > I've moved the document to > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw > . > > Please let me know if you need an invite to view the documen

Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-16 Thread Gail Badner
I've moved the document to https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw . Please let me know if you need an invite to view the document. The attachments are still at https://developer.jboss.org/wiki/ HibernateORMBinaryCompatibilityBetween51And53. Regards, Gail

[hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3

2018-03-16 Thread Gail Badner
Hi, There were lots of differences in the compatibility report, so as a first step, I've excluded packages/classes that I considered SPI, internal, or "grey area". This reduced the the differences to a more manageable amount. You can see a summary of the incompatibilities along with suggested mit