Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Sanne Grinovero
On Wed, 5 Dec 2018 at 20:10, Steve Ebersole wrote: > > Another one.. > > `hibernate-orm-modules` defines a `hibernate-envers` module (in the WF > modules sense). Since envers is now part of `hibernate-core` should we > remove that module or have it just act as an alias for the main orm module? R

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Steve Ebersole
At this point I feel comfortable that everything is good to go for Alpha1. I've done a few dry runs using just publish and it looks good. I have not yet tried the full set of release tasks. I am having trouble getting the staging hibernate.org build to work[1]. So I won't be able to publish the

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Guillaume Smet
On Wed, Dec 5, 2018 at 4:47 PM Steve Ebersole wrote: > On Wed, Dec 5, 2018 at 9:28 AM Guillaume Smet > wrote: > >> So it's a detail but it's pretty handy to have relocations for these >> artifacts in the case of our test case template as we can test various >> versions without changing anything.

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Steve Ebersole
Comments inline. However, a general point - the argument about "seamless" support for people upgrading is a bit misguided here I think. The argument is that someone can just change the version and everything will work as before. But we know that is not the case. They will also have to change th

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Steve Ebersole
On Wed, Dec 5, 2018 at 9:28 AM Guillaume Smet wrote: There are a few artifacts we need to decide how to handle: >> >>- `hibernate-entitymanager` and `hibernate-java8` have been part of > > >>`hibernate-core` since 5.2 (I thought moving `hibernate-entitymanager` >>happened way earlier,

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Sanne Grinovero
On Wed, 5 Dec 2018 at 13:56, Steve Ebersole wrote: > > As I am preparing the Alpha1 release a few topics of discussion have come > up... > > Previously (last year's f2f) we had decided to unify the artifact naming > conventions; specifically for ORM this meant renaming the groupId from > `org.hibe

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Guillaume Smet
Hi, On Wed, Dec 5, 2018 at 2:47 PM Steve Ebersole wrote: > Previously (last year's f2f) we had decided to unify the artifact naming > conventions; specifically for ORM this meant renaming the groupId from > `org.hibernate` to `org.hibernate.orm` as part of 6.0. I wanted to see if > everyone sti

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Steve Ebersole
Do you guys feel the same way about `hibernate-envers`? Or should we relocate that for a few? On Wed, Dec 5, 2018 at 8:51 AM Vlad Mihalcea wrote: > Hi, > > I also agree with Christian. For the `hibernate-entitymanager`, the problem > came from Spring as they wanted to support multiple versions

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Vlad Mihalcea
Hi, I also agree with Christian. For the `hibernate-entitymanager`, the problem came from Spring as they wanted to support multiple versions of Hibernate. I wrote them on Twitter about this change so that they can adjust their framework to accommodate it. Vlad On Wed, Dec 5, 2018 at 3:53 PM Chr

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Christian Beikov
Am 05.12.2018 um 15:20 schrieb Steve Ebersole: > Another one.. > > `hibernate-orm-modules` defines a `hibernate-envers` module (in the WF > modules sense). Since envers is now part of `hibernate-core` should we > remove that module or have it just act as an alias for the main orm module? IMO a maj

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Steve Ebersole
Another one.. `hibernate-orm-modules` defines a `hibernate-envers` module (in the WF modules sense). Since envers is now part of `hibernate-core` should we remove that module or have it just act as an alias for the main orm module? On Wed, Dec 5, 2018 at 7:54 AM Steve Ebersole wrote: > One ot

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Steve Ebersole
One other artifact note... `hibernate-envers` has been merged into `hibernate-core` as of 6. Should we just drop this one since this is a new major release? Or do the relocation for a few? On Wed, Dec 5, 2018 at 7:42 AM Steve Ebersole wrote: > As I am preparing the Alpha1 release a few topics

Re: [hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Christian Beikov
Am 05.12.2018 um 14:42 schrieb Steve Ebersole: > As I am preparing the Alpha1 release a few topics of discussion have come > up... > > Previously (last year's f2f) we had decided to unify the artifact naming > conventions; specifically for ORM this meant renaming the groupId from > `org.hibernate`

[hibernate-dev] 6.0 Alpha1 prep

2018-12-05 Thread Steve Ebersole
As I am preparing the Alpha1 release a few topics of discussion have come up... Previously (last year's f2f) we had decided to unify the artifact naming conventions; specifically for ORM this meant renaming the groupId from `org.hibernate` to `org.hibernate.orm` as part of 6.0. I wanted to see if