Re: [hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Yoann Rodiere
Well, if you don't mind me sending PRs with those imports in a different order next time I change the file (because I don't spend time on organizing imports manually, I just use CTRL+SHIFT+O), then yes, we can leave that undefined. Yoann Rodière Hibernate NoORM Team yo...@hibernate.org On 12 Sept

Re: [hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Sanne Grinovero
On 12 September 2017 at 10:49, Yoann Rodiere wrote: > Well, if you don't mind me sending PRs with those imports in a different > order next time I change the file (because I don't spend time on organizing > imports manually, I just use CTRL+SHIFT+O), then yes, we can leave that > undefined. That

Re: [hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Guillaume Smet
On Tue, Sep 12, 2017 at 11:45 AM, Sanne Grinovero wrote: > Yes I'm "ok" with that. But wouldn't it be even better to leave this > level of detail undefined? > > At least it would allow me to make new code having them on the bottom > as I like them more, and you'd save some itme :) > The issue is

Re: [hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Sanne Grinovero
On 12 September 2017 at 10:42, Yoann Rodiere wrote: >> Fundamentally no IDE will ever produce exactly the same code so you >> need to learn control your primal lust for perfection and remember >> it's not relevant. Have some decency ;) > > > Sorry if that seemed "indecent", but I did mention that

Re: [hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Yoann Rodiere
> > Fundamentally no IDE will ever produce exactly the same code so you > need to learn control your primal lust for perfection and remember > it's not relevant. Have some decency ;) Sorry if that seemed "indecent", but I did mention that I could live with the inconsistencies, and that what matte

Re: [hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Guillaume Smet
Hi, Yes, I had a hard time reverting the import changes in my recent patches for ORM. I was changing only a few lines per file and had a lot of import noise. I would say that it would be nice to have Eclipse and Idea rules as similar as possible. The issue with that is that, for a while, the ORM

Re: [hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Sanne Grinovero
Fundamentally no IDE will ever produce exactly the same code so you need to learn control your primal lust for perfection and remember it's not relevant. Have some decency ;) What does actually matter is that we don't keep chaging the order as it introduces conflicts on backporting, it's very anno

[hibernate-dev] [SEARCH] Code style - imports

2017-09-12 Thread Yoann Rodiere
Hello all, I just noticed that our IDEA codestyle configuration files have specific rules about how to organize imports, whereas the Eclipse ones don't. The most noticeable difference: organizing imports in Eclipse puts static imports at the top, while in IDEA they end up at the bottom. But there