On Tue, 15 Jan 2019 at 14:24, Guillaume Smet wrote:
>
> > A minor nitpick: not logging which entities are being enhanced seems
> reasonable when ORM is being booted, but as a user I'd probably expect
> to see such output if I'm running an explicit enhancement task via
> some of the tooling.
> > Pe
> A minor nitpick: not logging which entities are being enhanced seems
reasonable when ORM is being booted, but as a user I'd probably expect
to see such output if I'm running an explicit enhancement task via
some of the tooling.
> Perhaps you should allow the enhancer tasks to raise these back up
Sounds good to me! :)
On Fri, Jan 11, 2019 at 8:19 AM Sanne Grinovero wrote:
> On Fri, 11 Jan 2019 at 14:00, Steve Ebersole wrote:
> >
> > Guillaume - I added a general start-a-discussion comment to the PR.
> Hopefully anyone with an opinion on that can chime in there. Beyond that,
> +1
> >
>
On Fri, 11 Jan 2019 at 14:00, Steve Ebersole wrote:
>
> Guillaume - I added a general start-a-discussion comment to the PR.
> Hopefully anyone with an opinion on that can chime in there. Beyond that, +1
>
>
> Sanne - ok, I see. You are not expecting users to have to deal with
> wrapping/scrol
Guillaume - I added a general start-a-discussion comment to the PR.
Hopefully anyone with an opinion on that can chime in there. Beyond
that, +1
Sanne - ok, I see. You are not expecting users to have to deal with
wrapping/scrolling because you limit the presented information to an
arbitrary set
On Fri, 11 Jan 2019 at 09:53, Guillaume Smet wrote:
>
> So what I suggest: if you disagree on a change, just comment on the specific
> line of the PR and I'll revert.
>
> I plan to merge that on Tuesday.
I like it. Not merging it yet to get Steve a chance to comment too.
A minor nitpick: not lo
On Thu, 10 Jan 2019 at 16:39, Steve Ebersole wrote:
>
>
>
> On Thu, Jan 10, 2019 at 10:15 AM Sanne Grinovero wrote:
>>
>> On Thu, 10 Jan 2019 at 01:44, Steve Ebersole wrote:
>> >
>> > I disagree that logging a single message is a better solution because that
>> > probably ends up wrapping multi
So what I suggest: if you disagree on a change, just comment on the
specific line of the PR and I'll revert.
I plan to merge that on Tuesday.
On Fri, Jan 11, 2019 at 10:24 AM Guillaume Smet
wrote:
> In meeting all day so making progress on dumb stuff.
>
> Here is a very conservative PR on which
In meeting all day so making progress on dumb stuff.
Here is a very conservative PR on which I hope we could agree on quickly:
https://github.com/hibernate/hibernate-orm/pull/2728
--
Guillaume
On Thu, Jan 10, 2019 at 5:38 PM Steve Ebersole wrote:
>
>
> On Thu, Jan 10, 2019 at 10:15 AM Sanne G
On Thu, Jan 10, 2019 at 10:15 AM Sanne Grinovero
wrote:
> On Thu, 10 Jan 2019 at 01:44, Steve Ebersole wrote:
> >
> > I disagree that logging a single message is a better solution because
> that probably ends up wrapping multiple lines, just as your sample happened
> to do in the email. IMO tha
On Thu, 10 Jan 2019 at 01:44, Steve Ebersole wrote:
>
> I disagree that logging a single message is a better solution because that
> probably ends up wrapping multiple lines, just as your sample happened to do
> in the email. IMO that is actually more difficult to read.
Ok keep it in one line
I disagree that logging a single message is a better solution because that
probably ends up wrapping multiple lines, just as your sample happened to
do in the email. IMO that is actually more difficult to read.
And I just do not understand this idea that we have to direct people to
enable logging
Pretty good idea but definitely too much work for the effort I want to put
in it right now.
But, yes, we can do that for version 7.0.1.Final, I like your example :).
I will make a proposal to reduce the log verbosity (enhanced classes,
hibernate.properties missing and a few others) but keep the i
+1 to polish output, but:
I don't want to need to figure out how to reconfigure whatever Logger
of the day one happens to hit, to finally notice that essential
configuration details are wrong. Mostly because it requires to get the
idea to actually check this, which is not a straightforward thought
Yeah sure, they will be kept as is just moved to DEBUG.
The only one that would change is the "Processing PersistenceUnitInfo"
thing: we will remove the INFO one and keep the more detailed DEBUG one.
BTW, I agree with everything Steve said, sorry for not replying earlier.
On Mon, Jan 7, 2019 at
See below.
On 1/3/19 10:29 AM, Steve Ebersole wrote:
> [o.h.d.Dialect] (main) HHH000400: Using dialect:
>> org.hibernate.dialect.PostgreSQL95Dialect
>>
>> -> wondering if it has any value to log the dialect? I mean if you don't
>> use the right one, you will definitely have some issues.
>>
> True,
In general I agree with everything you said, but had a few specific
comments in line...
> [o.h.j.i.u.LogHelper] (main) HHH000204: Processing PersistenceUnitInfo [
> name: templatePU
> ...]
>
> -> so, first, I would make this one a one liner as we apparently didn't add
> any other proper
Hi,
Got a report from a fellow Red Hatter complaining about our logging
verbosity being so 2004 and, well, I must admit I tend to agree.
This is from a launch on a simple PostgreSQL app. I added some comments
inline.
Note that it might seem like wasting our time but I would like to improve
the u
18 matches
Mail list logo
