Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-24 Thread Emmanuel Bernard
On 24 Jun 2014, at 15:07, Gunnar Morling wrote: > 2014-06-24 14:55 GMT+02:00 Emmanuel Bernard : > > On 24 Jun 2014, at 11:50, Gunnar Morling wrote: > >> Yes, today we don't. >> >> But is there any reason for not using the value column name? > > Not more that the ones I outlined in this thre

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-24 Thread Gunnar Morling
2014-06-24 14:55 GMT+02:00 Emmanuel Bernard : > > On 24 Jun 2014, at 11:50, Gunnar Morling wrote: > > Yes, today we don't. > > But is there any reason for not using the value column name? > > > Not more that the ones I outlined in this thread. > > In fact that's what my pending PR > https://githu

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-24 Thread Emmanuel Bernard
On 24 Jun 2014, at 11:50, Gunnar Morling wrote: > Yes, today we don't. > > But is there any reason for not using the value column name? Not more that the ones I outlined in this thread. > In fact that's what my pending PR > https://github.com/hibernate/hibernate-ogm/pull/337 does for MongoDB

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-24 Thread Gunnar Morling
Yes, today we don't. But is there any reason for not using the value column name? In fact that's what my pending PR https://github.com/hibernate/hibernate-ogm/pull/337 does for MongoDB. Right now it even allows to work with different value column names for the same table (either in the same or in

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-23 Thread Emmanuel Bernard
On 19 Jun 2014, at 14:54, Gunnar Morling wrote: >> valueColumnName is something that I elected no to use because NoSQL we bind >> to so far do not have a strong schema. And at at given segmentColumnValue >> only correspond a single value. It would come and bite me if someone for the >> same s

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-19 Thread Gunnar Morling
2014-06-19 13:34 GMT+02:00 Emmanuel Bernard : > > On 19 Jun 2014, at 11:12, Gunnar Morling wrote: > > I'm looking into this atm. > > My thinking is to pass a new dedicated Type IdGeneratorKey instead of > RowKey to GridDialect#nextVal() which can carry all the information we > need. The dual use

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-19 Thread Emmanuel Bernard
On 19 Jun 2014, at 11:12, Gunnar Morling wrote: > I'm looking into this atm. > > My thinking is to pass a new dedicated Type IdGeneratorKey instead of RowKey > to GridDialect#nextVal() which can carry all the information we need. The > dual use of RowKey for association rows and sequences has

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-19 Thread Gunnar Morling
I'm looking into this atm. My thinking is to pass a new dedicated Type IdGeneratorKey instead of RowKey to GridDialect#nextVal() which can carry all the information we need. The dual use of RowKey for association rows and sequences has been confusing anyways. 2014-06-06 10:44 GMT+02:00 Emmanuel B

Re: [hibernate-dev] [OGM] Id generation strategies

2014-06-06 Thread Emmanuel Bernard
I guess it is particularly questionable to have an identity generator be mapped to an ad-hoc table based generator. Remember the angle we came from: make a JPA application work when storing data in Infinispan. Unlike other datastores, Infinispan has not notion of id generation whatsoever. seque

[hibernate-dev] [OGM] Id generation strategies

2014-06-04 Thread Gunnar Morling
Hi, I'm rather confused by the way how OgmIdentityGenerator, OgmSequenceGenerator and OgmTableGenerator interact. Basically, the first two just delegate to the latter. Now intuitively I'd have expected an exception when explicitly using a generation type not supported on a given datastore, say @G