Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Davide D'Alto
> Anyways, the reg exp approach seems to work, so I don't want to bother you :) No problem, it's actually a way to see if what I'm doing make sense :) On Thu, Apr 25, 2013 at 2:55 PM, Gunnar Morling wrote: > 2013/4/25 Davide D'Alto > >> Thanks Gunnar, >> >> in the .gitattributes file we defin

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Gunnar Morling
2013/4/25 Davide D'Alto > Thanks Gunnar, > > in the .gitattributes file we define the rule that says that all the new > lines must be converted to "lf" when pushing on the repository. > When someone clone the repository all the files seems to have "lf" has new > line character. > Interesting, ac

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Davide D'Alto
Thanks Gunnar, in the .gitattributes file we define the rule that says that all the new lines must be converted to "lf" when pushing on the repository. When someone clone the repository all the files seems to have "lf" has new line character. The error happens because checkstyle uses the system n

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Gunnar Morling
Davide, It works on my Mac, too. I'm wondering though why the original NewlineAtEndOfFile rule didn't work on all systems. There is a property "lineSeparator" which defaults to "system" as per the docs, which I had understood to do the right thing on all platforms. Have you tried setting it to "s

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Davide D'Alto
Awesome, Thanks On Thu, Apr 25, 2013 at 12:51 PM, Guillaume SCHEIBEL < guillaume.schei...@gmail.com> wrote: > I ran both "mvn clean compile" and "mvn checkstyle:checkstyle" on my > windows laptop and got 2 "build success". > > Guillaume > > > 2013/4/25 Davide D'Alto > >> Thanks you Gunnar, >> >

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Guillaume SCHEIBEL
I ran both "mvn clean compile" and "mvn checkstyle:checkstyle" on my windows laptop and got 2 "build success". Guillaume 2013/4/25 Davide D'Alto > Thanks you Gunnar, > > Davide > > > On Thu, Apr 25, 2013 at 12:07 PM, Gunnar Morling >wrote: > > > > > Am 25.04.2013 12:34 schrieb "Davide D'Alto"

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Davide D'Alto
Thanks you Gunnar, Davide On Thu, Apr 25, 2013 at 12:07 PM, Gunnar Morling wrote: > > Am 25.04.2013 12:34 schrieb "Davide D'Alto" : > > > > > Thanks Guillaume, > > are you going to test it on Windows isn't? > > > > We still need a volunteer with a Mac. > > I can do that. > > --Gunnar > > > > >

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Davide D'Alto
Thanks Guillaume, are you going to test it on Windows isn't? We still need a volunteer with a Mac. On Thu, Apr 25, 2013 at 11:10 AM, Guillaume SCHEIBEL < guillaume.schei...@gmail.com> wrote: > hello, > > I'm checking and keep you up to date. > > Guillaume > > > 2013/4/25 Davide D'Alto > >> Hi,

Re: [hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Guillaume SCHEIBEL
hello, I'm checking and keep you up to date. Guillaume 2013/4/25 Davide D'Alto > Hi, > we have a problem with one of the rules in checkstyle: NewLineAtEndOfFile > > It seems that this rule in Windows is using the wrong character to check if > there is a new line at the end of a file. > > To s

[hibernate-dev] [OGM] Checkstyle rule failing in Windows

2013-04-25 Thread Davide D'Alto
Hi, we have a problem with one of the rules in checkstyle: NewLineAtEndOfFile It seems that this rule in Windows is using the wrong character to check if there is a new line at the end of a file. To solve this issue I've tried to remove the rule and use a regular expression instead. The problem i