Re: [hibernate-dev] [Hibernate Search] Added a test utility to assert produced log

2016-11-04 Thread Steve Ebersole
Sweet. Good to know On Fri, Nov 4, 2016 at 9:30 AM Sanne Grinovero wrote: > On 4 November 2016 at 14:27, Steve Ebersole wrote: > > I think we should consider creating a set of generic testing utils as a > > separate project. Things like LoggerInspectionRule, @ExpectedFailure, > > @BeforeClas

Re: [hibernate-dev] [Hibernate Search] Added a test utility to assert produced log

2016-11-04 Thread Sanne Grinovero
On 4 November 2016 at 14:27, Steve Ebersole wrote: > I think we should consider creating a set of generic testing utils as a > separate project. Things like LoggerInspectionRule, @ExpectedFailure, > @BeforeClassOnce, @AfterClassOnce, @Skip, etc are generally useful I find +1 for the general test

Re: [hibernate-dev] [Hibernate Search] Added a test utility to assert produced log

2016-11-04 Thread Steve Ebersole
I think we should consider creating a set of generic testing utils as a separate project. Things like LoggerInspectionRule, @ExpectedFailure, @BeforeClassOnce, @AfterClassOnce, @Skip, etc are generally useful I find On Fri, Nov 4, 2016 at 9:16 AM Sanne Grinovero wrote: > Nice trick! > > I didn'

Re: [hibernate-dev] [Hibernate Search] Added a test utility to assert produced log

2016-11-04 Thread Sanne Grinovero
Nice trick! I didn't know about the Log4j feature, but had created something similar for JBoss Logging; it's in the ORM project though so not easily reusable in all of Search components: - org.hibernate.testing.logger.LoggerInspectionRule On 4 November 2016 at 13:41, Yoann Rodiere wrote: > Hi t

[hibernate-dev] [Hibernate Search] Added a test utility to assert produced log

2016-11-04 Thread Yoann Rodiere
Hi team, Just so you know, if you ever need to assert that a certain log is produced in your JUnit tests, there's now a tool to do just that in Hibernate Search: org.hibernate.search.test.util.impl.ExpectedLog4jLog [1] You may use it much like you would use the ExpectedException rule: public cla