Re: [hibernate-dev] [HV] ThreadLocal in ValidatorImpl

2012-01-10 Thread Sanne Grinovero
Hi Hardy, could you not use a single object parameter to which you add all fields you need? ThreadLocals are never a good idea imho, I'd use it only if you have no other choice (like can't break some API). It took some time to remove them from Infinispan, much better now. Is it just these two eleme

Re: [hibernate-dev] [HV] ThreadLocal in ValidatorImpl

2012-01-10 Thread Gunnar Morling
Hi, I think a good start for HV-439 would be to check for superfluous type parameters. There a several parameterized methods in ValidatorImpl which have unnecessary type parameters (mea culpa). I think ValidatorImpl will look much simpler afterwards. Regarding the ThreadLocal, I'm not sure. This

[hibernate-dev] [HV] ThreadLocal in ValidatorImpl

2012-01-10 Thread Hardy Ferentschik
Hi, I was thinking about https://hibernate.onjira.com/browse/HV-439 which basically also means a refactoring of the current ValidatorImpl. One thing I noticed is that we start at one of the public Bean Validation methods and then create different context (e.g. ValueContext, ValidationConext) wh