2011/3/1 Emmanuel Bernard :
> Hi Hardy,
> Nice job.
>
> Here are a few comments in random order:
>
> To avoid the problem of Constructor multiplications and still use immutable
> objects use a builder to collect the information and create the object out of
> it. The constructor can even be packag
On Tue, 01 Mar 2011 17:34:58 +0100, Emmanuel Bernard
wrote:
>>> FacetRequest request =
>>> carBuilder
>>> .facet()
>>>.named("prices")
>>>.range() //or should it be range(Integer.class)
>>>.onField("price")
>>>.from(0).to(1000).excludeLimit()
>>>.from(1000).to(1500).exclude
On 1 mars 2011, at 15:08, Hardy Ferentschik wrote:
> Thanks for the feedback. Answers inline
>
> On Tue, 01 Mar 2011 14:39:58 +0100, Emmanuel Bernard
> wrote:
>
>> To avoid the problem of Constructor multiplications and still use immutable
>> objects use a builder to collect the information
Thanks for the feedback. Answers inline
On Tue, 01 Mar 2011 14:39:58 +0100, Emmanuel Bernard
wrote:
> To avoid the problem of Constructor multiplications and still use
> immutable objects use a builder to collect the information and create
> the object out of it. The constructor can even b
Hi Hardy,
Nice job.
Here are a few comments in random order:
To avoid the problem of Constructor multiplications and still use immutable
objects use a builder to collect the information and create the object out of
it. The constructor can even be package private
My initial reaction was that fa
Thanks for the feedback Sanne!
On Mon, 28 Feb 2011 19:56:59 +0100, Sanne Grinovero
wrote:
> I've been reading this focusing on the tests and the Collectors
> implementation.
That's the most interesting part. There are a few unrelated cleanup and
testing
related commits which as you say I
Hi Hardy,
great job!
I've been reading this focusing on the tests and the Collectors implementation.
If you want me to have a look at all the patches, could you please
squash some commits :)
Comments:
1) why is it named SimpleFacetRequest, are you planning for a more advanced one?
2) I couldn't f
Hi,
I thought it would be great to get some feedback on my faceting work.
You can see the latest on my Search fork -
https://github.com/hferentschik/hibernate-search/commits/HSEARCH-667
Technically I decided to use a simple custom Collector. I abandoned the
idea for using bobo browse, since
