Re: [hibernate-dev] [HSEARCH-670] Add indexNullAs to @IndexedEmbedded

2011-08-12 Thread Davide D'Alto
Maybe we can add an option like "boolean emptyAsNull" to IndexEmbedded. On Fri, Aug 12, 2011 at 12:31 PM, Davide D'Alto wrote: > I've first written a simple test and then I chose the parameters > accordingly so that the test can pass. > Before investingate further I wanted to ask if there are alr

Re: [hibernate-dev] [HSEARCH-670] Add indexNullAs to @IndexedEmbedded

2011-08-12 Thread Davide D'Alto
I've first written a simple test and then I chose the parameters accordingly so that the test can pass. Before investingate further I wanted to ask if there are already some defaults to use in this case. An empty collection is not a null so my patch shouldn't change the existing behaviour. I need

Re: [hibernate-dev] [HSEARCH-670] Add indexNullAs to @IndexedEmbedded

2011-08-12 Thread Sanne Grinovero
Hi Davide, as Index option I would use Index.NOT_ANALYZED_NO_NORMS; ANALYZED is not a proper fit as it might break the marker token in pieces and get some unpredictable behaviour. About Store .. do you need to store it? I assume you do to mark the difference between a null collection and an empty

[hibernate-dev] [HSEARCH-670] Add indexNullAs to @IndexedEmbedded

2011-08-12 Thread Davide D'Alto
Hello, I've created a prototype for HSEARCH-670: https://github.com/DavideD/hibernate-search/commits/HSEARCH-670 It seems to work but I'm not sure about the options to use indexing the null value. At the moment it uses the following LucenOption object: LuceneOptions options = new LuceneOptionsImp