Re: [hibernate-dev] [HSEARCH] package split in API/SPI/private aka HSEARCH-746

2011-06-21 Thread Emmanuel Bernard
I've been working on the backend side and made the following split api Workspace TransactionContext OptimizerStrategy LuceneWork and *LuceneWork spi WorkType Work Worker UpdatableBackendQueueProcessorFactory BackendQueueProcessorFactory LuceneIndexingParameters impl WorkVisitor WorkQueue WorkerFa

Re: [hibernate-dev] [HSEARCH] package split in API/SPI/private aka HSEARCH-746

2011-06-20 Thread Emmanuel Bernard
>> 2. Specific issues: >> o org.hibernate.search.batchindexing.impl.Executors is used by >> MutablefactoryTest >> should we keep executors as private or should we consider it an actual API >> or SPI? > > I don't think exposing this as SPI is very useful to people, but at > some point in future

Re: [hibernate-dev] [HSEARCH] package split in API/SPI/private aka HSEARCH-746

2011-05-11 Thread Sanne Grinovero
2011/5/11 Hardy Ferentschik : > See answers inline > >>> 1. >>> API vs SPI: >>> http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-746 >>> >>> I have a question on API vs SPI. >>> The Hibernate Core team uses the following rule: >>>  - any "public" API not directly called by the user

Re: [hibernate-dev] [HSEARCH] package split in API/SPI/private aka HSEARCH-746

2011-05-11 Thread Hardy Ferentschik
See answers inline >> 1. >> API vs SPI: >> http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-746 >> >> I have a question on API vs SPI. >> The Hibernate Core team uses the following rule: >> - any "public" API not directly called by the user application is a >> SPI (for exampl

Re: [hibernate-dev] [HSEARCH] package split in API/SPI/private aka HSEARCH-746

2011-05-11 Thread Sanne Grinovero
2011/5/10 Emmanuel Bernard : > I've started the work to split classes between API, SPI and private classes. > Some areas went very well, some are more problematic but that was to be > expected. Anyways it did generate a couple of questions from philosophical to > concrete. Please try and chime in

Re: [hibernate-dev] [HSEARCH] package split in API/SPI/private aka HSEARCH-746

2011-05-10 Thread Steve Ebersole
Well technically I define an SPI as anything Hibernate consumes to perform a function on its behalf. Essentially anything that users, frameworks, app servers, etc "plug in" to Hibernate to tell it how to handle certain things. The contract for that would be an SPI. Notice this covers Type/Use

[hibernate-dev] [HSEARCH] package split in API/SPI/private aka HSEARCH-746

2011-05-10 Thread Emmanuel Bernard
I've started the work to split classes between API, SPI and private classes. Some areas went very well, some are more problematic but that was to be expected. Anyways it did generate a couple of questions from philosophical to concrete. Please try and chime in. 1. API vs SPI: http://opensource.