Re: [hibernate-dev] [BVAL]

2011-06-08 Thread Hardy Ferentschik
On Tue, 07 Jun 2011 21:46:05 +0200, Gunnar Morling wrote: > Does the document also relate to the TCK? the assertions are matched against statements in the spec using a file called tck-audit.xml. So there is definitely a connection, but the connection w/ the api is tighter imo > What forma

Re: [hibernate-dev] [BVAL]

2011-06-07 Thread Gunnar Morling
+1 on having the spec. on github. Does the document also relate to the TCK? If so it maybe makes sense to have it within a third repo next to beanvalidation-api and beanvalidation-tck. Otherwise putting it into beanvalidation-api seems good. What format will the document have? -- Gunnar 2011/6

Re: [hibernate-dev] [BVAL]

2011-06-07 Thread Hardy Ferentschik
On Tue, 07 Jun 2011 09:10:15 +0200, Emmanuel Bernard wrote: > Guys I'm considering releasing the specification document as a Git > repository. > I am wondering if the document should share the same Git repo as > beanvalidation-api or if these two should be kept separated. In other > words

[hibernate-dev] [BVAL]

2011-06-07 Thread Emmanuel Bernard
Guys I'm considering releasing the specification document as a Git repository. I am wondering if the document should share the same Git repo as beanvalidation-api or if these two should be kept separated. In other words, do these share the same release / tag cycle all the time? WDYT? Note that

Re: [hibernate-dev] [BVAL] POM Versions

2009-03-17 Thread Alaa Mohsen
Actually, the case was that we installed the artifacts on the local repository of the CI virtual machine and not on our corporate repository. The reason we did that was so that the builds for the reference implementation won't break when the API changes. Since we used the same CI server for other p

Re: [hibernate-dev] [BVAL] POM Versions

2009-03-16 Thread Steve Ebersole
Are y'all using SNAPSHOT versioning in your development poms? By the same logic below y'all should be using SNAPSHOT in your poms and explicitly setting a version during release. - Steve Ebersole Project Lead http://hibernate.org st...@hibernate.org Principal Software Engineer JBoss, a divi

Re: [hibernate-dev] [BVAL] POM Versions

2009-03-16 Thread Hardy Ferentschik
On Mon, 16 Mar 2009 15:27:06 +0100, Alaa Mohsen wrote: Well, we have our own integration server which installs the new builds to our local repository. I uninstalled the new artifacts with the wrong version, and got the ones from the older ones and we fixed our builds. What I meant by affect

Re: [hibernate-dev] [BVAL] POM Versions

2009-03-16 Thread Alaa Mohsen
Well, we have our own integration server which installs the new builds to our local repository. I uninstalled the new artifacts with the wrong version, and got the ones from the older ones and we fixed our builds. What I meant by affecting the released version is for the people with cases like ours

Re: [hibernate-dev] [BVAL] POM Versions

2009-03-16 Thread Emmanuel Bernard
Ah year that's my fault. But Isn't beta4 up in the maven cloud? I don't understand why what I commit in trunk does affect released versions? On Mar 15, 2009, at 04:46, Alaa Mohsen wrote: Hello guys, I'm facing a problem right now, and the problem is that we currently have Hibernate

[hibernate-dev] [BVAL] POM Versions

2009-03-15 Thread Alaa Mohsen
Hello guys, I'm facing a problem right now, and the problem is that we currently have Hibernate Validator Alpha 2 as a dependency in our project, which has the Validation API Beta 4 as a dependency. The problem is that the latest changes in the API (including those in the Message Interpolator)

Re: [hibernate-dev] [BVAL-RI] Issue in MetaConstraint constructor

2009-02-24 Thread Hardy Ferentschik
On Tue, 24 Feb 2009 14:49:59 +0100, Alaa Mohsen wrote: Hello guys, We faced a problem with in-house constraints that were used to annotate classes (Target = ElementType.TYPE). When we debugged a little, we found out that the MetaConstraint constrictor that takes Type t sets the eleme

[hibernate-dev] [BVAL-RI] Issue in MetaConstraint constructor

2009-02-24 Thread Alaa Mohsen
Hello guys, We faced a problem with in-house constraints that were used to annotate classes (Target = ElementType.TYPE). When we debugged a little, we found out that the MetaConstraint constrictor that takes Type t sets the element type as ElementType.FIELD. I created issue HV-123

Re: [hibernate-dev] [BVAL-RI] Regarding @Size

2009-02-23 Thread Emmanuel Bernard
Yes, make sense http://opensource.atlassian.com/projects/hibernate/browse/BVAL-125 On Feb 22, 2009, at 17:32, Alaa Mohsen wrote: Hello Guys, I was thinking about something. Why do we have the default value for min() in the Size constraint set to Integer.MIN_VALUE and not zero? I know

[hibernate-dev] [BVAL-RI] Regarding @Size

2009-02-22 Thread Alaa Mohsen
Hello Guys, I was thinking about something. Why do we have the default value for min() in the Size constraint set to Integer.MIN_VALUE and not zero? I know that this won't make any difference at all for the validation framework, but I don't think that it's logical to say that there is a negati

Re: [hibernate-dev] [BVAL-RI] Unit Test Failure

2009-02-22 Thread Hardy Ferentschik
Hi Alaa, thanks for the info. I will fix the unit tests. I actaully passes on my machine, but I can see that it could fail. Really one can not rely on the order of the constraint violations. I'll fix it asap. --Hardy On Sun, 22 Feb 2009 14:04:26 +0100, Alaa Mohsen wrote: Hello Guys,

Re: [hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Hardy Ferentschik
Great. Just to make sure that we don't work on the same things - could you contact the asignee in case you want to work on on an already assigned task? In many cases the person is more than happy to drop a task, but just has to know ;-) In case you start working on an unassinged task make sure

[hibernate-dev] [BVAL-RI] Renamed several constraints

2009-02-02 Thread Alaa Mohsen
Hi all, To follow the naming convention, I renamed the constraint validators for Past, Null and NotNull. I created a JIRA issue for that BVAL-105, and attached the patches ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jbos

Re: [hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Alaa Mohsen
OK. So no need for me to implement it then. Got a couple of meetings, then I'll look at what I can do in the RI Regards, Alaa Nassef On Mon, Feb 2, 2009 at 3:50 PM, Hardy Ferentschik wrote: > Hi, > > I am actually implementing this as we speak. I need it in order to > implement > BVAL-99. And ye

Re: [hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Hardy Ferentschik
Hi, I am actually implementing this as we speak. I need it in order to implement BVAL-99. And yes, it ends up to be a static map. --Hardy What's the status of BVAL-90 (Stop using a properties file for built-in constraints and move to a list in Java)? I'm thinking of implementing it u

Re: [hibernate-dev] [BVAL-RI] Implementing built in constraint validators

2009-02-02 Thread Hardy Ferentschik
Hi, no worries. I applied your patch and also fixed the big. Thanks for the patch. --Hardy On Mon, 02 Feb 2009 12:09:30 +0100, Alaa Mohsen wrote: Hello Guys, I implemented most constraint validators yesterday and added a patch on JIRA. There was a small bug in the AssertFalse v

Re: [hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Alaa Mohsen
I have a question. When you said to add the map at the ValidatorFactory level, did you mean to add it to ValidatorFactoryImpl? As I can see, getting the validators of built in constraints happens in ConstraintDescriptorImpl, which is used only by the BeanMetaDataImpl. Do I put the map in Constraint

Re: [hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Alaa Mohsen
OK On Mon, Feb 2, 2009 at 1:31 PM, Emmanuel Bernard wrote: > Actually I am sure now, you have to store the list in a Map at the > ValidatorFactory level because the list of validators can be overridden in > XML. > > > On Feb 2, 2009, at 12:28, Emmanuel Bernard wrote: > > I don't see the need fo

Re: [hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Emmanuel Bernard
Actually I am sure now, you have to store the list in a Map at the ValidatorFactory level because the list of validators can be overridden in XML. On Feb 2, 2009, at 12:28, Emmanuel Bernard wrote: I don't see the need for reflection. Just add them to the map, period. You might want to sto

Re: [hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Emmanuel Bernard
I don't see the need for reflection. Just add them to the map, period. You might want to store the map in the ValidatorFactory instead of a static, not sure. On Feb 2, 2009, at 12:22, Alaa Mohsen wrote: Hello All, What's the status of BVAL-90 (Stop using a properties file for built-

[hibernate-dev] [BVAL-RI] Regarding BVAL-90

2009-02-02 Thread Alaa Mohsen
Hello All, What's the status of BVAL-90 (Stop using a properties file for built-in constraints and move to a list in Java)? I'm thinking of implementing it using a static map that's get filled on class loading. I wanted to have a clean implementation using reflection, but can't find a clean so

[hibernate-dev] [BVAL-RI] Implementing built in constraint validators

2009-02-02 Thread Alaa Mohsen
Hello Guys, I implemented most constraint validators yesterday and added a patch on JIRA. There was a small bug in the AssertFalse validator, and I fixed it, and added another patch to be used in place of the one attached yesterday. Wasn't able to delete the old attachemnt, since I don't have

Re: [hibernate-dev] [BVAL-RI] HibrnateValidatorConfiguration

2009-01-31 Thread Hardy Ferentschik
On Sat, 31 Jan 2009 14:34:42 +0100, Emmanuel Bernard wrote: BTW, either ValidationContext has a bad name or ValidatorContext has a bad name but one of them has to change: - ValidationContext => ValidatorExectionContext? Agreed. The whole Validation vs Validator thing gets me all the tim

Re: [hibernate-dev] [BVAL-RI] HibrnateValidatorConfiguration

2009-01-31 Thread Emmanuel Bernard
On Jan 31, 2009, at 06:08, Hardy Ferentschik wrote: On Sat, 31 Jan 2009 07:49:24 +0100, Emmanuel Bernard > wrote: I don't think HibernateValidatorConfiguration should go in the engine package. That's a public API. it should stay in the root package. Ok. The main point was to remove the

[hibernate-dev] [BVAL-RI] HibrnateValidatorConfiguration

2009-01-30 Thread Emmanuel Bernard
I don't think HibernateValidatorConfiguration should go in the engine package. That's a public API. it should stay in the root package. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev