Re: [hibernate-dev] "Service" in Hibernate Search: history, lessons learned and rewrite

2016-04-27 Thread Sanne Grinovero
I can't mention Service w/o getting your attention :) On 27 April 2016 at 13:34, Hardy Ferentschik wrote: > Hi, > >> Yet it is a good idea nowadays to have LuceneWorkSerializer extend >> Service, as we dropped that level of flexibility. This implies that >> there's a single type of serializer (at

Re: [hibernate-dev] "Service" in Hibernate Search: history, lessons learned and rewrite

2016-04-27 Thread Sanne Grinovero
On 27 April 2016 at 11:35, Gunnar Morling wrote: > Hey Sanne, > > great write-up! > > 2016-04-27 0:04 GMT+02:00 Sanne Grinovero : >> >> The "Service" and "ServiceManager" concepts in Hibernate Search have a >> specific meaning which is often misunderstood and/or abused, causing >> trouble. >> >> T

Re: [hibernate-dev] "Service" in Hibernate Search: history, lessons learned and rewrite

2016-04-27 Thread Sanne Grinovero
On 27 April 2016 at 10:33, Davide D'Alto wrote: > This is an interesting sum up. > Shouldn't we keep these thoughts in a separate document for developer? > > Together with some higher level diagrams of the architecture, maybe. I indeed wrote it as you expressed need for an high-level overview of

Re: [hibernate-dev] "Service" in Hibernate Search: history, lessons learned and rewrite

2016-04-27 Thread Hardy Ferentschik
Hi, > Yet it is a good idea nowadays to have LuceneWorkSerializer extend > Service, as we dropped that level of flexibility. This implies that > there's a single type of serializer (at most) Ok > and it's totally fine to expose this as: >SearchIntegrator#getLuceneWorkSerializer() How is tha

Re: [hibernate-dev] "Service" in Hibernate Search: history, lessons learned and rewrite

2016-04-27 Thread Gunnar Morling
Hey Sanne, great write-up! 2016-04-27 0:04 GMT+02:00 Sanne Grinovero : > The "Service" and "ServiceManager" concepts in Hibernate Search have a > specific meaning which is often misunderstood and/or abused, causing > trouble. > > They also changed over time: victim of two major refactorings whic

Re: [hibernate-dev] "Service" in Hibernate Search: history, lessons learned and rewrite

2016-04-27 Thread Davide D'Alto
This is an interesting sum up. Shouldn't we keep these thoughts in a separate document for developer? Together with some higher level diagrams of the architecture, maybe. On Tue, Apr 26, 2016 at 11:04 PM, Sanne Grinovero wrote: > The "Service" and "ServiceManager" concepts in Hibernate Search

[hibernate-dev] "Service" in Hibernate Search: history, lessons learned and rewrite

2016-04-26 Thread Sanne Grinovero
The "Service" and "ServiceManager" concepts in Hibernate Search have a specific meaning which is often misunderstood and/or abused, causing trouble. They also changed over time: victim of two major refactorings which evolved the purpose and stretching its intent So I'll change the definition agai